Skip to content

feat(explorer): render todo lists#104357

Merged
roaga merged 5 commits intomasterfrom
explorer/todo-ui
Dec 4, 2025
Merged

feat(explorer): render todo lists#104357
roaga merged 5 commits intomasterfrom
explorer/todo-ui

Conversation

@roaga
Copy link
Copy Markdown
Contributor

@roaga roaga commented Dec 3, 2025

show ui for todo list tool (copy in screenshot is outdated)
Screenshot 2025-12-03 at 2 50 20 PM

Part of AIML-1692

backend: https://github.com/getsentry/seer/pull/4174

@linear
Copy link
Copy Markdown

linear bot commented Dec 3, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 3, 2025
@roaga roaga requested a review from aliu39 December 3, 2025 23:03
@roaga roaga marked this pull request as ready for review December 3, 2025 23:03
@roaga roaga requested a review from a team as a code owner December 3, 2025 23:03
Base automatically changed from explorer/better-file-approval-ui to master December 4, 2025 20:12
: todo.status === 'in_progress'
? `_${todo.content}_`
: todo.content;
return `${checkbox} ${content}`;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Task list checkboxes missing list item marker prefix

The todosToMarkdown function generates markdown without the required list item marker (-). GFM task list syntax requires the format - [x] item or - [ ] item, but the current code produces [x] item or [ ] item. Without the leading hyphen, the markdown parser won't recognize these as task list items, so checkboxes will render as plain text [x] and [ ] instead of actual checkbox UI elements.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intended

)}
</ToolCallTextContainer>
{showTodoList && (
<TodoListContent text={todosToMarkdown(block.todos!)} />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Duplicate todo list rendering with multiple tool calls

The showTodoList condition is evaluated inside the tool_calls.map() loop, checking isTodoWriteCall for each tool call independently. If a block contains multiple todo_write tool calls and is the latest todo block, the same block.todos array gets rendered under each todo_write call, causing duplicate todo list UI elements. The code lacks a check to ensure the todo list is only rendered once per block rather than once per matching tool call.

Fix in Cursor Fix in Web

@roaga roaga merged commit 3d93f63 into master Dec 4, 2025
49 checks passed
@roaga roaga deleted the explorer/todo-ui branch December 4, 2025 21:17
ryan953 pushed a commit that referenced this pull request Dec 9, 2025
show ui for todo list tool (copy in screenshot is outdated)
<img width="863" height="470" alt="Screenshot 2025-12-03 at 2 50 20 PM"
src="https://github.com/user-attachments/assets/46eb9a93-515b-46f0-9c96-296877845721"
/>

Part of AIML-1692

backend: getsentry/seer#4174
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants