Skip to content

feat(insights): Adds sub region selectors to web vitals pages #104321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwardgou-sentry merged 2 commits into from
Dec 3, 2025
Merged

feat(insights): Adds sub region selectors to web vitals pages #104321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23389f
adds sub region selectors to web vitals pages
edwardgou-sentry Dec 3, 2025
c4838ae
fix test
edwardgou-sentry Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/app/views/insights/browser/webVitals/views/pageOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import PerformanceScoreBreakdownChartWidget from 'sentry/views/insights/common/c
import {useModuleTitle} from 'sentry/views/insights/common/utils/useModuleTitle';
import {useModuleURL} from 'sentry/views/insights/common/utils/useModuleURL';
import {useWebVitalsDrawer} from 'sentry/views/insights/common/utils/useWebVitalsDrawer';
import SubregionSelector from 'sentry/views/insights/common/views/spans/selectors/subregionSelector';
import {FrontendHeader} from 'sentry/views/insights/pages/frontend/frontendPageHeader';
import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters';
import {ModuleName, SpanFields, type SubregionCode} from 'sentry/views/insights/types';
Expand Down Expand Up @@ -158,6 +159,7 @@ function PageOverview() {
<TopMenuContainer>
<ModulePageFilterBar moduleName={ModuleName.VITAL} />
<BrowserTypeSelector />
<SubregionSelector />
</TopMenuContainer>
<Flex>
<ChartContainer>
Expand Down
18 changes: 15 additions & 3 deletions static/app/views/insights/browser/webVitals/views/webVitalsLandingPage.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,22 @@ describe('WebVitalsLandingPage', () => {
initialRouterConfig,
});
await waitForElementToBeRemoved(() => screen.queryAllByTestId('loading-indicator'));
// Table query
// geo subregion query
expect(eventsMock).toHaveBeenNthCalledWith(
1,
expect.anything(),
expect.objectContaining({
query: expect.objectContaining({
dataset: 'spans',
field: ['user.geo.subregion', 'count()'],
query: 'has:user.geo.subregion',
}),
})
);
// Table query
expect(eventsMock).toHaveBeenNthCalledWith(
2,
expect.anything(),
expect.objectContaining({
query: expect.objectContaining({
dataset: 'spans',
Expand Down Expand Up @@ -117,7 +129,7 @@ describe('WebVitalsLandingPage', () => {
);
// Raw web vital metric tile queries
expect(eventsMock).toHaveBeenNthCalledWith(
2,
3,
expect.anything(),
expect.objectContaining({
query: expect.objectContaining({
Expand All @@ -137,7 +149,7 @@ describe('WebVitalsLandingPage', () => {
);
// Project performance score ring query
expect(eventsMock).toHaveBeenNthCalledWith(
3,
4,
expect.anything(),
expect.objectContaining({
query: expect.objectContaining({
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/insights/browser/webVitals/views/webVitalsLandingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {ModulePageFilterBar} from 'sentry/views/insights/common/components/modul
import {ModulePageProviders} from 'sentry/views/insights/common/components/modulePageProviders';
import {ModulesOnboarding} from 'sentry/views/insights/common/components/modulesOnboarding';
import {useWebVitalsDrawer} from 'sentry/views/insights/common/utils/useWebVitalsDrawer';
import SubregionSelector from 'sentry/views/insights/common/views/spans/selectors/subregionSelector';
import {ModuleName, SpanFields, type SubregionCode} from 'sentry/views/insights/types';

const WEB_VITALS_COUNT = 5;
Expand Down Expand Up @@ -78,6 +79,7 @@ function WebVitalsLandingPage() {
extraFilters={
<Fragment>
<BrowserTypeSelector />
<SubregionSelector />
</Fragment>
}
/>
Expand Down
Loading