feat(preprod): skip renames from showing in diff#104306
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104306 +/- ##
===========================================
+ Coverage 80.53% 80.61% +0.07%
===========================================
Files 9350 9332 -18
Lines 400071 399195 -876
Branches 25658 25474 -184
===========================================
- Hits 322203 321808 -395
+ Misses 77400 76937 -463
+ Partials 468 450 -18 |
# Conflicts: # src/sentry/preprod/size_analysis/models.py
trevor-e
commented
Dec 5, 2025
|
|
||
| When a file with the same hash exists at different paths in head vs base, | ||
| we consider it a rename. However, if there are more paths on one side | ||
| (e.g., file was renamed AND duplicated), we only mark min(head, base) |
Member
Author
There was a problem hiding this comment.
This rename + duplication case I could see happening in real iOS apps with how folks duplicate frameworks across plugins so felt was worth handling.
rbro112
reviewed
Dec 6, 2025
|
|
||
| ### | ||
| # Size analysis results (non-comparison) | ||
| # Keep in sync with https://github.com/getsentry/launchpad/blob/main/src/launchpad/size/models/common.py#L92 |
Member
There was a problem hiding this comment.
Love some "strict" type safety 😂
rbro112
approved these changes
Dec 6, 2025
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
This skips renames (same file hash, different path) from showing up in the comparison results. A recent Xcode26 change made this way more prominent since every compilation changes a generated UUID in app icon image paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skips renames (same file hash, different path) from showing up in the comparison results. A recent Xcode26 change made this way more prominent since every compilation changes a generated UUID in app icon image paths.