chore(API): Remove old unused symbol sources url path#104298
chore(API): Remove old unused symbol sources url path#104298
Conversation
github-actions
bot
added
the
Scope: Backend
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104298 +/- ##
===========================================
+ Coverage 80.52% 80.60% +0.07%
===========================================
Files 9342 9339 -3
Lines 399115 399216 +101
Branches 25560 25560
===========================================
+ Hits 321391 321790 +399
+ Misses 77275 76977 -298
Partials 449 449 |
ceorourke
force-pushed
the
ceorourke/rm-old-symbol-sources-url
branch
from
ea91467 to
b69988e
Compare
| @responses.activate | ||
| def test_proxy_check_region_pinned_url(self) -> None: | ||
| responses.add( | ||
| responses.GET, | ||
| f"{self.REGION.address}/builtin-symbol-sources/", | ||
| json={"proxy": True}, | ||
| ) | ||
|
|
||
| # No /api/0 as we only include sentry.api.urls.urlpatterns | ||
| # and not sentry.web.urls which includes the version prefix | ||
| region_pinned = "/builtin-symbol-sources/" | ||
| control_url = reverse( | ||
| "control-endpoint", kwargs={"organization_slug": self.organization.slug} | ||
| ) | ||
|
|
||
| with override_settings(SILO_MODE=SiloMode.CONTROL, MIDDLEWARE=tuple(self.middleware)): | ||
| resp = self.client.get(region_pinned) | ||
| assert resp.status_code == 200 | ||
| resp_json = json.loads(close_streaming_response(resp)) | ||
| assert resp_json["proxy"] is True | ||
|
|
||
| resp = self.client.get(control_url) | ||
| assert resp.status_code == 200 | ||
| assert resp.data["proxy"] is False |
There was a problem hiding this comment.
Instead of deleting this test, could the URL name be changed to one we're likely to keep like sentry-js-sdk-loader?
There was a problem hiding this comment.
I'm not sure what I'm missing but I tried this and couldn't get it to work - it always 404s. I tried with a couple other pinned URLs too without success. I pushed up the change to use the js sdk loader in case you can see something I'm not.
ceorourke
force-pushed
the
ceorourke/rm-old-symbol-sources-url
branch
from
cfbfe6f to
4a912da
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ceorourke
force-pushed
the
ceorourke/rm-old-symbol-sources-url
branch
from
4094504 to
5fe2aa7
Compare
ceorourke
force-pushed
the
ceorourke/rm-old-symbol-sources-url
branch
from
c1442ae to
158e130
Compare
2 participants
We have a newer path to use since #56775 so we can remove this one now.