fix(ACI): pass trigger ID as kwarg to action -> ARTA serializer#104277
Merged
fix(ACI): pass trigger ID as kwarg to action -> ARTA serializer#104277
Conversation
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for the action -> alert rule trigger action serializer assumed that there would be a one to one relationship between detectors and workflows. This is not the case, as the new UI allows multiple workflows to be connected to a single detector. To prevent the
MultipleObjectsReturnederror from happening in the serializer, because the action -> ARTA serializer is only used within the context of detector -> alert rule serialization, we can pass in the correct trigger ID as a keyword argument.Fixes SENTRY-5C14