feat(crons): Add missing guides + consistency#104274
Merged
evanpurkhiser merged 1 commit intomasterfrom Dec 3, 2025
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
Dec 2, 2025
Comment on lines
26
to
+48
| CeleryBeatAutoDiscovery, | ||
| CLIUpsertPlatformGuide, | ||
| CurlUpsertPlatformGuide, | ||
| DenoUpsertPlatformGuide, | ||
| DotNetUpsertPlatformGuide, | ||
| ElixirObanPlatformGuide, | ||
| ElixirQuantumPlatformGuide, | ||
| ElixirUpsertPlatformGuide, | ||
| GoUpsertPlatformGuide, | ||
| JavaSpringBootUpsertPlatformGuide, | ||
| JavaUpsertPlatformGuide, | ||
| LaravelUpsertPlatformGuide, | ||
| NestJSUpsertPlatformGuide, | ||
| NextJSUpsertPlatformGuide, | ||
| NodeJsUpsertPlatformGuide, | ||
| PHPUpsertPlatformGuide, | ||
| PythonUpsertPlatformGuide, | ||
| RubyActiveJobPlatformGuide, | ||
| RubyRailsMixinPlatformGuide, | ||
| RubySidekiqAutoPlatformGuide, | ||
| RubySidekiqMixinPlatformGuide, | ||
| RubyUpsertPlatformGuide, | ||
| } from './quickStartEntries'; | ||
| } from './upsertPlatformGuides'; |
Member
Author
There was a problem hiding this comment.
These are what we added
evanpurkhiser
commented
Dec 2, 2025
Member
Author
There was a problem hiding this comment.
I moved the upsert guides out of here and into upsertPlatformGuides.tsx
evanpurkhiser
commented
Dec 2, 2025
Comment on lines
449
to
+492
| @@ -897,7 +474,7 @@ export function RubySidekiqCronQuickStart(props: QuickStartProps) { | |||
| const {slug} = withDefaultProps(props); | |||
|
|
|||
| const mixinCode = `class ExampleJob | |||
| incude Sidekiq::Job | |||
| include Sidekiq::Job | |||
| include Sentry::Cron::MonitorCheckIns | |||
|
|
|||
| # slug defaults to the job class name | |||
| @@ -909,10 +486,10 @@ export function RubySidekiqCronQuickStart(props: QuickStartProps) { | |||
| end`; | |||
|
|
|||
| const customCode = `# define the monitor config with an interval | |||
| sentry_monitor_check_ins slug: '${slug}', monitor_config: Sentry::Cron::MonitorConfig.from_interval(1, :minute) | |||
| sentry_monitor_check_ins slug: '${slug}', monitor_config: Sentry::Cron::MonitorConfig.from_interval(10, :minute) | |||
|
|
|||
| # define the monitor config with a crontab | |||
| sentry_monitor_check_ins slug: '${slug}', monitor_config: Sentry::Cron::MonitorConfig.from_crontab('5 * * * *')`; | |||
| sentry_monitor_check_ins slug: '${slug}', monitor_config: Sentry::Cron::MonitorConfig.from_crontab('*/10 * * * *')`; | |||
Member
Author
There was a problem hiding this comment.
Changes for consistency
gaprl
approved these changes
Dec 3, 2025
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-add-missing-guides-consistency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NEW-657: Add missing cron upsert onboarding guides