fix(typing): Add types to sentry.eventtypes by thetruecpaul · Pull Request #104258 · getsentry/sentry

thetruecpaul · 2025-12-02T18:03:33Z

Added some missing types and one assertion. (The assertion is a is not None in a case where it would've already thrown if None).

cvxluo · 2025-12-02T18:28:31Z

src/sentry/eventtypes/__init__.py

-    GenericEvent,
-    FeedbackEvent,
-]
+EventType = BaseEvent


do we still need this type?

Fair point! It's only used in one place, where we do need to distinguish between BaseEvent (an event type) and BaseEvent (a data model)... but I can just do an from X import Y as Z to keep things clear.

codecov · 2025-12-02T20:10:07Z

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
30223	4	30219	241

View the top 3 failed test(s) by shortest run time

tests.relay_integration.test_message_filters.FilterTests::test_should_not_filter_web_crawlers_when_disabled

Stack Traces | 0.983s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:275: in _raise_for_status
    response.raise_for_status()
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/requests/models.py#x1B[0m:1026: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
#x1B[1m#x1B[31mE   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker:.../localhost/v1.48....../containers/9362a732b68cae810e0a140142ed5342207c158bd584467d2eeeb27f03e5169b/start#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../testutils/pytest/relay.py#x1B[0m:137: in relay_server
    container = docker_client.containers.run(**options)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:883: in run
    container.start()
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:420: in start
    return self.client.api.start(self.id, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/utils/decorators.py#x1B[0m:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/container.py#x1B[0m:1136: in start
    self._raise_for_status(res)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:277: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/docker/errors.py#x1B[0m:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
#x1B[1m#x1B[31mE   docker.errors.APIError: 500 Server Error for http+docker:.../localhost/v1.48....../containers/9362a732b68cae810e0a140142ed5342207c158bd584467d2eeeb27f03e5169b/start: Internal Server Error ("failed to set up container networking: driver failed programming external connectivity on endpoint sentry_test_relay_server (13ed6ac3e47d12c9cd254ec9cded8941a0a1cfe2556a9878504074c1ef4455f4): failed to bind host port for 0.0.0.0:33331:172.18.0.11:33331/tcp: address already in use")#x1B[0m

tests.relay_integration.lang.java.test_plugin.BasicResolvingIntegrationTest::test_resolving_inline_with_native_frames

Stack Traces | 2.17s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:275: in _raise_for_status
    response.raise_for_status()
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/requests/models.py#x1B[0m:1026: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
#x1B[1m#x1B[31mE   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker:.../localhost/v1.48....../containers/a5406133cc682d6c0c992223612aba291a4e466b121644e97a4c9406b5992afc/start#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../testutils/pytest/relay.py#x1B[0m:137: in relay_server
    container = docker_client.containers.run(**options)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:883: in run
    container.start()
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:420: in start
    return self.client.api.start(self.id, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/utils/decorators.py#x1B[0m:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/container.py#x1B[0m:1136: in start
    self._raise_for_status(res)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:277: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/docker/errors.py#x1B[0m:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
#x1B[1m#x1B[31mE   docker.errors.APIError: 500 Server Error for http+docker:.../localhost/v1.48....../containers/a5406133cc682d6c0c992223612aba291a4e466b121644e97a4c9406b5992afc/start: Internal Server Error ("failed to set up container networking: driver failed programming external connectivity on endpoint sentry_test_relay_server (98995950347a09a45635609c57b5b4d5f25766978eb898771ae23ac631f057d9): failed to bind host port for 0.0.0.0:33331:172.18.0.11:33331/tcp: address already in use")#x1B[0m

tests.symbolicator.test_payload_full.SymbolicatorResolvingIntegrationTest::test_real_resolving

Stack Traces | 2.57s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:275: in _raise_for_status
    response.raise_for_status()
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/requests/models.py#x1B[0m:1026: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
#x1B[1m#x1B[31mE   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker:.../localhost/v1.48....../containers/92d790dfa7cdee5bcd11cb334047f5d4f5ccaab789a507c21ac33f86612bdd17/start#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../testutils/pytest/relay.py#x1B[0m:137: in relay_server
    container = docker_client.containers.run(**options)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:883: in run
    container.start()
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:420: in start
    return self.client.api.start(self.id, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/utils/decorators.py#x1B[0m:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/container.py#x1B[0m:1136: in start
    self._raise_for_status(res)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:277: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/docker/errors.py#x1B[0m:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
#x1B[1m#x1B[31mE   docker.errors.APIError: 500 Server Error for http+docker:.../localhost/v1.48....../containers/92d790dfa7cdee5bcd11cb334047f5d4f5ccaab789a507c21ac33f86612bdd17/start: Internal Server Error ("failed to set up container networking: driver failed programming external connectivity on endpoint sentry_test_relay_server (b3be9219e9724767096422f54a42040e6357e0d19a724fe65ee38f4f067630f2): failed to bind host port for 0.0.0.0:33331:172.18.0.11:33331/tcp: address already in use")#x1B[0m

tests.relay_integration.lang.javascript.test_plugin.TestJavascriptIntegration::test_nonhandled_frames_inapp_normalization

Stack Traces | 5.38s run time

#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:275: in _raise_for_status
    response.raise_for_status()
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/requests/models.py#x1B[0m:1026: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
#x1B[1m#x1B[31mE   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker:.../localhost/v1.48....../containers/4afc41a360b32271f5b469473a9d006254527922248de98f304ac250fe2dd5dc/start#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[.../testutils/pytest/relay.py#x1B[0m:137: in relay_server
    container = docker_client.containers.run(**options)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:883: in run
    container.start()
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/models/containers.py#x1B[0m:420: in start
    return self.client.api.start(self.id, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/utils/decorators.py#x1B[0m:19: in wrapped
    return f(self, resource_id, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/container.py#x1B[0m:1136: in start
    self._raise_for_status(res)
#x1B[1m#x1B[31m.venv/lib/python3.13.../docker/api/client.py#x1B[0m:277: in _raise_for_status
    raise create_api_error_from_http_exception(e) from e
#x1B[1m#x1B[31m.venv/lib/python3.13.../site-packages/docker/errors.py#x1B[0m:39: in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation) from e
#x1B[1m#x1B[31mE   docker.errors.APIError: 500 Server Error for http+docker:.../localhost/v1.48....../containers/4afc41a360b32271f5b469473a9d006254527922248de98f304ac250fe2dd5dc/start: Internal Server Error ("failed to set up container networking: driver failed programming external connectivity on endpoint sentry_test_relay_server (cc5cf30db971fed687e77686d8c320c59011fd5aec0a9b16a84ddb0f8b95559b): failed to bind host port for 0.0.0.0:33331:172.18.0.11:33331/tcp: address already in use")#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Added some missing types and one assertion. (The assertion is a `is not None` in a case where it would've already thrown if `None`).

thetruecpaul requested a review from a team December 2, 2025 18:03

thetruecpaul requested review from a team as code owners December 2, 2025 18:03

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 2, 2025

vercel bot deployed to Preview December 2, 2025 18:05 View deployment

cvxluo approved these changes Dec 2, 2025

View reviewed changes

thetruecpaul force-pushed the cpaul/120125/typestypes branch from 6178277 to fd195ca Compare December 2, 2025 19:49

vercel bot deployed to Preview December 2, 2025 19:51 View deployment

fix(typing): Add types to sentry.eventtypes

edb6fd4

Added some missing types and one assertion. (The assertion is a `is not None` in a case where it would've already thrown if `None`).

thetruecpaul force-pushed the cpaul/120125/typestypes branch from fd195ca to edb6fd4 Compare December 2, 2025 21:02

vercel bot deployed to Preview December 2, 2025 21:05 View deployment

thetruecpaul merged commit c3f6878 into master Dec 2, 2025
69 checks passed

thetruecpaul deleted the cpaul/120125/typestypes branch December 2, 2025 21:36

github-actions bot locked and limited conversation to collaborators Dec 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(typing): Add types to sentry.eventtypes#104258

fix(typing): Add types to sentry.eventtypes#104258
thetruecpaul merged 1 commit intomasterfrom
cpaul/120125/typestypes

thetruecpaul commented Dec 2, 2025

Uh oh!

cvxluo Dec 2, 2025

Uh oh!

thetruecpaul Dec 2, 2025

Uh oh!

codecov bot commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thetruecpaul commented Dec 2, 2025

Uh oh!

cvxluo Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

thetruecpaul Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 2, 2025

❌ 4 Tests Failed:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants