fix(ui): constrain compactSelect to the main section per default#104245
Merged
fix(ui): constrain compactSelect to the main section per default#104245
Conversation
JonasBa
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s what I found out:
react-ariacorrectly calculates amaxWidthdepending on the items we have in the list and the container it is “constrained” to.preventOverflowOptions.boundarymenuMaxWidth(we did that in 4 places only)In this PR, we:
boundaryto themainelement if not providedcalcexpression to get this down to 90% of the total width of that (as react-aria will just use the full space available otherwise)With that, we should get a good, unified rendering of the compactSelect menu that never gets too large. I have therefore removed the
menuMaxWidthprop, as I don’t think users should need to set that.before:
after: