Skip to content

fix(types): Fix return type of update_with_returning#104225

Merged
lobsterkatie merged 1 commit intomasterfrom
kmclb-fix-return-type-of-update_with_returning
Dec 2, 2025
Merged

fix(types): Fix return type of update_with_returning#104225
lobsterkatie merged 1 commit intomasterfrom
kmclb-fix-return-type-of-update_with_returning

Conversation

@lobsterkatie
Copy link
Copy Markdown
Member

@lobsterkatie lobsterkatie commented Dec 2, 2025

We have a custom queryset method called update_with_returning, modeled after the built-in Django queryset update method, which adds the ability to pull data from the updated rows. Though we're currently only using it to pull data from an a single integer column, there's nothing to say that's the only kind of data we could return (and in fact, we're about to use it to return data from multiple, non-int columns). This therefore fixes the return type to be Any n-tuples rather than int 1-tuples.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 2, 2025
@lobsterkatie lobsterkatie marked this pull request as ready for review December 2, 2025 02:17
@lobsterkatie lobsterkatie force-pushed the kmclb-fix-return-type-of-update_with_returning branch from cd81766 to 1c3799e Compare December 2, 2025 02:44
@lobsterkatie lobsterkatie requested a review from a team December 2, 2025 02:47
@lobsterkatie lobsterkatie merged commit 60082d4 into master Dec 2, 2025
103 of 132 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
@lobsterkatie lobsterkatie deleted the kmclb-fix-return-type-of-update_with_returning branch March 16, 2026 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants