fix(grouping): Use underscores in test hash values#104220
Merged
lobsterkatie merged 1 commit intomasterfrom Dec 2, 2025
Merged
fix(grouping): Use underscores in test hash values#104220lobsterkatie merged 1 commit intomasterfrom
lobsterkatie merged 1 commit intomasterfrom
Conversation
JoshFerge
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes a number of our tests to remove the spaces from test hash values. Until now it hasn't been an issue, but we'll soon be using hash values in cache keys, a context in which spaces aren't allowed. (In prod there never are spaces, so we only need to worry about tests.)