feat(segment-enrichment): Apply clusterer to segment names#104192
Merged
feat(segment-enrichment): Apply clusterer to segment names#104192
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jjbayer
approved these changes
Dec 2, 2025
also fixes a test case copy/paste error, and marks unused params in tests.
mjq
added a commit
that referenced
this pull request
Dec 11, 2025
) Last in a series of PRs (#103739, #103913, #104192) to port transaction name clustering to segment enrichment for segments. This adds the final step, bumping lifetime rules after their application. Since the arguments for transactions and segments are different, refactored the existing `_bump_rule_lifetime` into two entry points that munge arguments before passing them to the existing logic. Closes ENG-5952.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the work from #103739 and #103913.
This PR ports the application of transaction name clusterer rules from Relay into segment enrichment. Relay will continue to apply transaction name clustering to spans from transactions, while this code will handle standalone spans (spans v2) and OTLP spans.
See the preamble to
sentry.ingest.transaction_clusterer.treefor an explanation of how transaction name clustering rules are matched.Closes ENG-5747.