chore(cells) Finish adding silo annotations to View, Endpoint and functions

[markstory]

• Add silo annotations to the last batch of functions + views.
• Expand tests to ensure that all views, endpoints and functions have silo annotations applied.
• I added some exceptions for basic/builtin django views.

Refs INFRENG-202

[linear]

INFRENG-202 Add missing silo annotations to web views

[cursor]

Bug: Double silo decoration on partials causes redundant checks

The recover_confirm function is decorated with @control_silo_view, and then set_password_confirm and relocate_confirm wrap partial(recover_confirm, ...) with another control_silo_view(). Since the partial wraps the already-decorated function, this results in double decoration. When either partial is called, the silo mode check runs twice: once on the outer wrapper and once when the partial invokes the inner decorated recover_confirm. The fix would be to either remove the decorator from recover_confirm (if it's only accessed via partials) or not wrap the partials (and manually set the silo_limit attribute to satisfy the test).

Additional Locations (1)

• src/sentry/users/web/accounts.py#L197-L199

 

[markstory]

The redundancy is a cost I'm willing to accept for being able to write more thorough tests.

[GabeVillalobos]

Is this an extensive list of view classes we want to exclude from this? Should we consider making this a const list somewhere instead?

[markstory]

So far, these are the only django base views we're using. If we get any more of them a list would be better.

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
16469	1	16468	133

View the top 1 failed test(s) by shortest run time

tests.sentry.management.commands.test_generate_controlsilo_urls.TestGenerateControlsiloUrls::test_no_missing_urls

Stack Traces | 0.134s run time

#x1B[1m#x1B[.../management/commands/test_generate_controlsilo_urls.py#x1B[0m:67: in test_no_missing_urls
    assert line in current_state, msg
#x1B[1m#x1B[31mE   AssertionError: #x1B[0m
#x1B[1m#x1B[31mE                 New control silo URL patterns detected!#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE                 The pattern:   new RegExp('^auth-v2/'),#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE                 Does not exist in the current pattern inventory. You should regenerate#x1B[0m
#x1B[1m#x1B[31mE                 the pattern inventory with:#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE                 cd ../getsentry#x1B[0m
#x1B[1m#x1B[31mE                 getsentry django generate_controlsilo_urls --format=js --output=...../app/data/controlsiloUrlPatterns.ts#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE                 This command needs to be run in a getsentry environment#x1B[0m
#x1B[1m#x1B[31mE                 in order to not lose patterns that are important for sentry.io#x1B[0m
#x1B[1m#x1B[31mE                 #x1B[0m
#x1B[1m#x1B[31mE   assert "  new RegExp('^auth-v2/')," in "// This is generated code.\n// To update it run `getsentry django generate_controlsilo_urls --format=js --output=/pat....../github/installations/webhook/$'),\n  new RegExp('^share/(?:group|issue)/[^/]+/$'),\n];\n\nexport default patterns;\n"#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[github-actions]

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.