feat(preprod): expose status check data through build details API#104085
Merged
feat(preprod): expose status check data through build details API#104085
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
src/sentry/preprod/api/models/project_preprod_build_details_models.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104085 +/- ##
===========================================
- Coverage 80.61% 80.35% -0.27%
===========================================
Files 9319 9327 +8
Lines 397949 402609 +4660
Branches 25424 25424
===========================================
+ Hits 320801 323507 +2706
- Misses 76696 78650 +1954
Partials 452 452 |
trevor-e
commented
Dec 1, 2025
|
|
||
| def _parse_posted_status_checks(artifact: PreprodArtifact) -> PostedStatusChecks | None: | ||
| """Parse posted status checks from artifact extras, returning None for invalid data.""" | ||
| if not artifact.extras: |
Member
Author
There was a problem hiding this comment.
I'm looking into some better options for maintaining a schema for our JSON column, like maybe a pydantic model, so parsing this is less of a hassle going forward. But won't be part of this PR.
| def _parse_success_check(raw_size: dict[str, Any], artifact_id: int) -> StatusCheckResultSuccess: | ||
| """Parse a successful status check result.""" | ||
| check_id = raw_size.get("check_id") | ||
| if check_id is not None and not isinstance(check_id, str): |
Contributor
There was a problem hiding this comment.
yeah damn, lotta unwrapping - but will trust you to address later on!
| "error_type": error_type_str, | ||
| }, | ||
| ) | ||
| return StatusCheckResultFailure(error_type=error_type) |
Contributor
There was a problem hiding this comment.
I guess we'll handle a default error message / error type on the client?
Member
Author
There was a problem hiding this comment.
Yea the UI can show a specific message based on the error_type field.
NicoHinderling
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes this data to our frontend so we can build a success/error UI for posted checks.