Skip to content

feat(objectstore): Add proxying logic to endpoint#104045

Merged
lcian merged 32 commits intomasterfrom
lcian/feat/objectstore-endpoint
Dec 3, 2025
Merged

feat(objectstore): Add proxying logic to endpoint#104045
lcian merged 32 commits intomasterfrom
lcian/feat/objectstore-endpoint

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented Nov 26, 2025

This implements get/post/put/delete endpoints that simply proxy requests to the internal Objectstore service, as we don't want to expose it directly to the internet for now.

The endpoints stream the request bodies directly to Objectstore.

All endpoints are gated by the organizations:objectstore-endpoint feature flag which will be enabled only for sentry initially.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 26, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 26, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@lcian
Copy link
Copy Markdown
Member Author

lcian commented Nov 26, 2025

@sentry review

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 79.66102% with 24 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/objectstore/endpoints/organization.py 79.66% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104045      +/-   ##
===========================================
+ Coverage   80.59%    80.62%   +0.02%     
===========================================
  Files        9333      9333              
  Lines      398600    398900     +300     
  Branches    25497     25497              
===========================================
+ Hits       321271    321632     +361     
+ Misses      76879     76818      -61     
  Partials      450       450              

@lcian
Copy link
Copy Markdown
Member Author

lcian commented Dec 1, 2025

bugbot run

@lcian lcian disabled auto-merge December 3, 2025 13:45
@lcian lcian merged commit c32caeb into master Dec 3, 2025
68 checks passed
@lcian lcian deleted the lcian/feat/objectstore-endpoint branch December 3, 2025 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants