feat(aci): Add metric issue event details by malwilley · Pull Request #103995 · getsentry/sentry

malwilley · 2025-11-25T19:11:16Z

Adds something to the metric issue event details so it doesn't look so broken and tells the user why it triggered. Much more to add in the future, but this is a start

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx

scttcper · 2025-11-25T21:16:48Z

static/app/views/issueDetails/groupEventDetails/groupEventDetailsContent.tsx

          </ErrorBoundary>
        </Fragment>
      )}
+      {issueTypeConfig.metricDetectorTriggered.enabled && (


i think we don't need this, since we check that the event has a specific property

we've been trying to use the event to decide what to render where possible

Okay yeah good call, using the data source type now to make the determination

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx

codecov · 2025-12-01T19:01:52Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
12734	1	12733	10

View the top 1 failed test(s) by shortest run time

MetricDetectorTriggeredSection renders metric detector details with static condition

Stack Traces | 0.058s run time

TestingLibraryElementError: Unable to find an accessible element with the role "region" and name "Condition"

Here are the accessible roles:

  region:

  Name "Message":
  ...

  Name "Triggered Condition":
  ...

  --------------------------------------------------
  button:

  Name "Collapse Message Section":
  ...

  Name "Collapse Triggered Condition Section":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  group:

  Name "Collapse Message Section":
  ...

  Name "Collapse Triggered Condition Section":
  ...

  --------------------------------------------------
  separator:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  table:

  Name "":
  ...

  --------------------------------------------------
  rowgroup:

  Name "":
  ...

  --------------------------------------------------
  row:

  Name "Aggregate count()":
  ...

  Name "Query is:unresolved":
  ...

  Name "Interval 1 minute":
  ...

  Name "Condition Above 100":
  ...

  Name "Evaluated Value 150":
  ...

  --------------------------------------------------
  cell:

  Name "Aggregate":
  ...

  Name "count()":
  ...

  Name "Query":
  ...

  Name "is:unresolved":
  ...

  Name "Interval":
  ...

  Name "1 minute":
  ...

  Name "Condition":
  ...

  Name "Above 100":
  ...

  Name "Evaluated Value":
  ...

  Name "150":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../streamline/sidebar/metricDetectorTriggeredSection.spec.tsx:101:19)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx

malwilley added 2 commits November 25, 2025 11:01

feat(aci): Add metric issue event details

60af95a

Update test

0479e64

malwilley requested review from a team as code owners November 25, 2025 19:11

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025

vercel bot deployed to Preview November 25, 2025 19:12 View deployment

cursor bot reviewed Nov 25, 2025

View reviewed changes

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx Show resolved Hide resolved

malwilley added 2 commits November 25, 2025 11:29

Reorganize component

a549509

Update test

f5bf1b3

vercel bot deployed to Preview November 25, 2025 19:49 View deployment

scttcper reviewed Nov 25, 2025

View reviewed changes

Check the datasource type instead of an issue type config

ef41528

vercel bot deployed to Preview December 1, 2025 18:53 View deployment

sentry bot reviewed Dec 1, 2025

View reviewed changes

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx Show resolved Hide resolved

Fix test

9225b27

sentry bot reviewed Dec 1, 2025

View reviewed changes

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx Show resolved Hide resolved

vercel bot deployed to Preview December 1, 2025 22:26 View deployment

cursor bot reviewed Dec 1, 2025

View reviewed changes

static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx Show resolved Hide resolved

scttcper approved these changes Dec 1, 2025

View reviewed changes

Add one more error boundary to be safe

9728630

vercel bot deployed to Preview December 2, 2025 18:57 View deployment

malwilley merged commit 96fec29 into master Dec 2, 2025
48 checks passed

malwilley deleted the malwilley/feat/add-metric-issue-event-details branch December 2, 2025 19:27

github-actions bot locked and limited conversation to collaborators Dec 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(aci): Add metric issue event details#103995

feat(aci): Add metric issue event details#103995
malwilley merged 7 commits intomasterfrom
malwilley/feat/add-metric-issue-event-details

malwilley commented Nov 25, 2025

Uh oh!

Uh oh!

scttcper Nov 25, 2025

Uh oh!

scttcper Nov 25, 2025

Uh oh!

malwilley Dec 1, 2025

Uh oh!

Uh oh!

codecov bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

malwilley commented Nov 25, 2025

Uh oh!

Uh oh!

scttcper Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

scttcper Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

malwilley Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 1, 2025 •

edited

Loading