Skip to content

feat(aci): Display apdex option for spans#103791

Merged
scttcper merged 11 commits intomasterfrom
scttcper/add-apdex-option
Nov 25, 2025
Merged

feat(aci): Display apdex option for spans#103791
scttcper merged 11 commits intomasterfrom
scttcper/add-apdex-option

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Nov 20, 2025 •
edited
Loading

brings back apdex option for spans

stacked on #103697

image

@scttcper
fix(aci): Hide failure rate and hide string options for p50
dd5cb03 
- hides failure rate and failure count options from metric monitors
- hides string tags for aggregate functions like p50, p90
@scttcper
only disallow aggregates for logs
6e9ced7
@scttcper
Merge branch 'master' into scttcper/fix-aci-EAP-options
c4125b4
@scttcper
feat(aci): Display apdex option for spans
f85a038 
Adds back the apdex option and a test so it doesn't disappear.
@scttcper
move
00b02d3
@scttcper scttcper requested a review from a team as a code owner November 20, 2025 23:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025
cursor[bot]
cursor bot reviewed Nov 20, 2025
View reviewed changes
Base automatically changed from scttcper/fix-aci-EAP-options to master November 20, 2025 23:56
malwilley
malwilley reviewed Nov 20, 2025
View reviewed changes
static/app/views/detectors/components/forms/metric/visualize.tsx Outdated
const LOCKED_SPAN_AGGREGATES = {
[AggregationKey.APDEX]: {
value: DEFAULT_VISUALIZATION_FIELD,
label: t('span.duration'),
Copy link
Copy Markdown
Member

@malwilley malwilley Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be cleaner if you just set span.duration to be the single allowable type for this parameter

Copy link
Copy Markdown
Member Author

@scttcper scttcper Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is what this is doing, i've removed the disabled

@scttcper
Merge branch 'master' into scttcper/add-apdex-option
77e979e 
# Conflicts:
#	static/app/views/detectors/components/forms/metric/visualize.tsx
@scttcper
remove casting to any
3747cec
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12658 1 12657 10
View the top 1 failed test(s) by shortest run time 
DetectorEdit Metric disables column select when spans + count()
Stack Traces | 0.371s run time 
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button aria-disabled="false" aria-expanded="false" aria-haspopup="listbox" class="en302zp1 css-g0v7il-StyledButton-getColors-getFocusState-getColors-getSizeStyles-getBoxShadow-DO_NOT_USE_getButtonStyles-StyledButton e1hnfhxi2" data-react-aria-pressable="true" id="_r_uc_" role="button" tabindex="0" type="button" />
    at Object.toBeDisabled (.../views/detectors/edit.spec.tsx:609:22)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@scttcper scttcper merged commit 07b3483 into master Nov 25, 2025
47 checks passed
@scttcper scttcper deleted the scttcper/add-apdex-option branch November 25, 2025 00:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@malwilley malwilley malwilley approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scttcper @malwilley