Skip to content

Wire up frontend for new multiple architectures insight#103415

Merged
rbro112 merged 2 commits intomasterfrom
ryan/wire_up_frontend_for_new_multiple_architectures_insight
Nov 14, 2025
Merged

Wire up frontend for new multiple architectures insight#103415
rbro112 merged 2 commits intomasterfrom
ryan/wire_up_frontend_for_new_multiple_architectures_insight

Conversation

@rbro112
Copy link
Copy Markdown
Member

@rbro112 rbro112 commented Nov 14, 2025

Screenshot 2025-11-14 at 3 29 14 PM Screenshot 2025-11-14 at 3 23 37 PM

Also renames AppleInsightResults to InsightResults since it's not apple-specific

Resolves EME-643

@rbro112 rbro112 requested a review from a team as a code owner November 14, 2025 23:29
Copy link
Copy Markdown
Member Author

rbro112 commented Nov 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 14, 2025
Comment on lines 170 to 176
* Process all insights into a standardized format for display
*/
export function processInsights(
insights: AppleInsightResults,
insights: InsightResults,
totalSize: number
): ProcessedInsight[] {
const processedInsights: ProcessedInsight[] = [];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: New insight multiple_native_library_archs lacks UI support, preventing the 'How to fix' button and modal from functioning.
Severity: HIGH | Confidence: 1.00

🔍 Detailed Analysis

The new insight type 'multiple_native_library_archs' is added to the processing logic but lacks corresponding UI support. The INSIGHTS_WITH_MORE_INFO_MODAL array does not include this new key, preventing the 'How to fix this locally' button from rendering. Additionally, the handleOpenModal function lacks a case for 'multiple_native_library_archs', meaning even if the button were visible, clicking it would not trigger the modal. This prevents users from accessing help information for this new insight.

💡 Suggested Fix

Add 'multiple_native_library_archs' to the INSIGHTS_WITH_MORE_INFO_MODAL array and implement a handler for this insight type within the handleOpenModal function.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/preprod/utils/insightProcessing.ts#L170-L176

Potential issue: The new insight type 'multiple_native_library_archs' is added to the
processing logic but lacks corresponding UI support. The `INSIGHTS_WITH_MORE_INFO_MODAL`
array does not include this new key, preventing the 'How to fix this locally' button
from rendering. Additionally, the `handleOpenModal` function lacks a case for
'multiple_native_library_archs', meaning even if the button were visible, clicking it
would not trigger the modal. This prevents users from accessing help information for
this new insight.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2700774

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant, we don't have a how to fix modal for this one

@linear
Copy link
Copy Markdown

linear bot commented Nov 14, 2025

@rbro112 rbro112 merged commit 8f0e5df into master Nov 14, 2025
49 checks passed
@rbro112 rbro112 deleted the ryan/wire_up_frontend_for_new_multiple_architectures_insight branch November 14, 2025 23:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants