Wire up frontend for new multiple architectures insight#103415
Wire up frontend for new multiple architectures insight#103415
Conversation
| * Process all insights into a standardized format for display | ||
| */ | ||
| export function processInsights( | ||
| insights: AppleInsightResults, | ||
| insights: InsightResults, | ||
| totalSize: number | ||
| ): ProcessedInsight[] { | ||
| const processedInsights: ProcessedInsight[] = []; |
There was a problem hiding this comment.
Bug: New insight multiple_native_library_archs lacks UI support, preventing the 'How to fix' button and modal from functioning.
Severity: HIGH | Confidence: 1.00
🔍 Detailed Analysis
The new insight type 'multiple_native_library_archs' is added to the processing logic but lacks corresponding UI support. The INSIGHTS_WITH_MORE_INFO_MODAL array does not include this new key, preventing the 'How to fix this locally' button from rendering. Additionally, the handleOpenModal function lacks a case for 'multiple_native_library_archs', meaning even if the button were visible, clicking it would not trigger the modal. This prevents users from accessing help information for this new insight.
💡 Suggested Fix
Add 'multiple_native_library_archs' to the INSIGHTS_WITH_MORE_INFO_MODAL array and implement a handler for this insight type within the handleOpenModal function.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/preprod/utils/insightProcessing.ts#L170-L176
Potential issue: The new insight type 'multiple_native_library_archs' is added to the
processing logic but lacks corresponding UI support. The `INSIGHTS_WITH_MORE_INFO_MODAL`
array does not include this new key, preventing the 'How to fix this locally' button
from rendering. Additionally, the `handleOpenModal` function lacks a case for
'multiple_native_library_archs', meaning even if the button were visible, clicking it
would not trigger the modal. This prevents users from accessing help information for
this new insight.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2700774
There was a problem hiding this comment.
Not relevant, we don't have a how to fix modal for this one

Also renames
AppleInsightResultstoInsightResultssince it's not apple-specificResolves EME-643