feat(perforce): Add backend support for Perforce integration#103171
Merged
feat(perforce): Add backend support for Perforce integration#103171
Conversation
Contributor
|
This PR is 2500 lines -- would it possible to split it up for review? There are aspects that should be reviewed by different teams like dependencies, specific features, etc |
f566dcc to
ab41785
Compare
2172a79 to
09e3105
Compare
Contributor
Author
e293bd2 to
2a52e60
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103171 +/- ##
===========================================
- Coverage 80.59% 80.54% -0.06%
===========================================
Files 9297 9297
Lines 396850 397078 +228
Branches 25281 25281
===========================================
- Hits 319839 319809 -30
- Misses 76551 76809 +258
Partials 460 460 |
a978a06 to
1197dcd
Compare
2a52e60 to
ecfa2ce
Compare
Contributor
Christinarlong
left a comment
There was a problem hiding this comment.
Could we break this PR down more to be on the feature level? This PR is still pretty insane to review and push out at once since there's like 4-5 features here. Maybe something like
- integration installation & authentication ?
- stacktrace linking
- repository management
- releases/commit tracking
- suspect commits
494bf1d to
58c2354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds backend support for Perforce version control integration:
Requires: #103287