Skip to content

feat(perforce): Add backend support for Perforce integration#103171

Merged
mujacica merged 31 commits intomasterfrom
feat/perforce-backend
Dec 4, 2025
Merged

feat(perforce): Add backend support for Perforce integration#103171
mujacica merged 31 commits intomasterfrom
feat/perforce-backend

Conversation

@mujacica
Copy link
Copy Markdown
Contributor

@mujacica mujacica commented Nov 11, 2025

This commit adds backend support for Perforce version control integration:

  • New Perforce integration with P4 client support
  • Installation logic
  • Tests for integration

Requires: #103287

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 11, 2025
@cathteng
Copy link
Copy Markdown
Contributor

This PR is 2500 lines -- would it possible to split it up for review? There are aspects that should be reviewed by different teams like dependencies, specific features, etc

@mujacica mujacica force-pushed the feat/perforce-backend branch from f566dcc to ab41785 Compare November 13, 2025 12:05
@mujacica mujacica changed the base branch from master to feat/perforce-integration November 13, 2025 12:05
@mujacica mujacica force-pushed the feat/perforce-backend branch 2 times, most recently from 2172a79 to 09e3105 Compare November 13, 2025 12:10
@mujacica
Copy link
Copy Markdown
Contributor Author

Hey @cathteng, I extracted the stubs/generic code/dependencies into another PR: #103287

This one now contains only perforce-related logic and tests (note that 70% of the lines in the PR now are coming from the tests themselves).

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 10.88710% with 221 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/perforce/integration.py 13.38% 123 Missing ⚠️
src/sentry/integrations/perforce/client.py 7.54% 98 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103171      +/-   ##
===========================================
- Coverage   80.59%    80.54%   -0.06%     
===========================================
  Files        9297      9297              
  Lines      396850    397078     +228     
  Branches    25281     25281              
===========================================
- Hits       319839    319809      -30     
- Misses      76551     76809     +258     
  Partials      460       460              

@mujacica mujacica force-pushed the feat/perforce-integration branch from a978a06 to 1197dcd Compare November 13, 2025 12:35
@mujacica mujacica force-pushed the feat/perforce-backend branch from 2a52e60 to ecfa2ce Compare November 13, 2025 12:37
@mujacica mujacica marked this pull request as ready for review November 13, 2025 13:00
@mujacica mujacica requested review from a team as code owners November 13, 2025 13:00
Copy link
Copy Markdown
Contributor

@Christinarlong Christinarlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we break this PR down more to be on the feature level? This PR is still pretty insane to review and push out at once since there's like 4-5 features here. Maybe something like

  • integration installation & authentication ?
  • stacktrace linking
  • repository management
  • releases/commit tracking
  • suspect commits

@mujacica mujacica merged commit 8f2406f into master Dec 4, 2025
66 checks passed
@mujacica mujacica deleted the feat/perforce-backend branch December 4, 2025 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants