-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(ios): Detect dynamic linkage from the Podfile when USE_FRAMEWORKS is unset #6621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+45
โ4
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d2ca67
fix(ios): Force-load the Sentry static archive to keep ObjC category โฆ
antonis 8c1a078
fix(ios): Place Sentry -force_load on the target whose link strips
antonis dc780c5
fix(ios): Use -ObjC instead of -force_load for Sentry categories
antonis f12d6e2
Merge remote-tracking branch 'origin/main' into fix/ios-force-load-seโฆ
antonis d082a3a
fix(ios): Revert to -force_load for Sentry categories (-ObjC regressed)
antonis 2a2fb0d
fix(ios): Detect dynamic linkage from the Podfile when USE_FRAMEWORKSโฆ
antonis cdfc721
Merge remote-tracking branch 'origin/main' into fix/ios-linkage-detecโฆ
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
sentry_uses_dynamic_linkagecheck is too broad. It incorrectly detects dynamic linkage in mixed-target projects, causing build flags to be misapplied, which can lead to runtime crashes.Severity: HIGH
Suggested Fix
The logic should be changed to check the linkage setting of the specific target that actually includes the
RNSentrypod, rather than checking if any target in the Podfile uses dynamic linkage. This will ensure the-force_loadflag is correctly applied based onRNSentry's context.Prompt for AI Agent