ref(boto3): Split integration into internal modules - #7537
Merged
Merged
Conversation
pabloDeputter
added this pull request to stack #7539
September 18, 2026 14:23
Contributor
Codecov Results 📊✅ 132233 passed | ⏭️ 7214 skipped | Total: 139447 | Pass Rate: 94.83% | Execution Time: 440m 53s 📊 Comparison with Base Branch
➖ Removed Tests (60)View removed tests
All tests are passing successfully. ✅ Patch coverage is 90.24%. Project has 2551 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.30% 90.29% -0.01%
==========================================
Files 195 198 +3
Lines 26261 26279 +18
Branches 9798 9798 —
==========================================
+ Hits 23714 23728 +14
- Misses 2547 2551 +4
- Partials 1485 1485 —Generated by Codecov Action |
pabloDeputter
removed this pull request from stack #7539
September 18, 2026 15:08
pabloDeputter
added this pull request to stack #7541
September 18, 2026 15:08
pabloDeputter
marked this pull request as ready for review
September 18, 2026 15:12
ericapisani
requested changes
Sep 18, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ericapisani
approved these changes
Sep 21, 2026
ericapisani
left a comment
ericapisani
left a comment
Member
There was a problem hiding this comment.
Thanks for making the earlier changes. There's one more change that we can try and make to avoid the need for dynamic imports altogether, have left a comment within one of the methods explaining.
Otherwise, this LGTM, approving in order to not block once that's been addressed
| def _sentry_before_sign( | ||
| request: "AWSRequest", signature_version: "Any", **kwargs: "Any" | ||
| ) -> None: | ||
| from sentry_sdk.integrations.boto3 import Boto3Integration |
Member
There was a problem hiding this comment.
A fun thing that you can do to try and get around the need for this dynamic import - you can provide the string rather than the class to client.get_integration.
So I think lines 117 and 118 below would look like this:
if client.get_integration("Boto3Integration") is None:
return
Member
Author
There was a problem hiding this comment.
Okay good to know, I didn't knew this was possible. Then we'll probably use client.get_integration("boto3") instead, right? Since we use boto3 as identifier for the integration.
Member
Author
There was a problem hiding this comment.
I'll do this probably in a later PR, cause I don't want to do merge hell once again 😭
Member
There was a problem hiding this comment.
Sounds good, totally understandable 👍🏻
pabloDeputter
force-pushed
the
pablo/refactor-boto3-integration
branch
4 times, most recently
from
September 22, 2026 14:53
5bbe368 to
591151d
Compare
pabloDeputter
removed this pull request from stack #7541
September 22, 2026 14:57
pabloDeputter
added this pull request to stack #7618
September 22, 2026 14:57
pabloDeputter
force-pushed
the
pablo/refactor-boto3-integration
branch
from
September 29, 2026 08:34
591151d to
81fd35f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 81fd35f. Configure here.
pabloDeputter
force-pushed
the
pablo/refactor-boto3-integration
branch
from
September 30, 2026 12:04
8bf4d1c to
a45c039
Compare
pabloDeputter
removed this pull request from stack #7618
September 30, 2026 12:05
pabloDeputter
added this pull request to stack #7792
September 30, 2026 12:05
pabloDeputter
force-pushed
the
pablo/refactor-boto3-integration
branch
from
September 30, 2026 13:31
c9e19dc to
d4858fe
Compare
pabloDeputter
force-pushed
the
pablo/refactor-boto3-integration
branch
from
September 30, 2026 14:05
d4858fe to
b21b888
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
Boto3Integrationfrom single module into package with smaller internal modules._client.py._instrumentation.py.from sentry_sdk.integrations.boto3 import Boto3Integration.