Repository navigation
Fix typo. - #717
Merged
Merged
Fix typo.#717
Conversation
untitaker
approved these changes
Jun 9, 2020
untitaker
left a comment
untitaker
left a comment
Member
There was a problem hiding this comment.
Thanks, can you run make format locally and commit the result?
untitaker
approved these changes
Jun 9, 2020
Contributor
Author
|
@untitaker I didn't any changes in that string https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/integrations/aiohttp.py#L54, because I don't is it reasonable. I catched this exception because aiohttp has not parseable version https://github.com/aio-libs/aiohttp/releases/tag/v4.0.0a1. |
Member
|
@lmasikl I agree, can you put this change into your PR? I am surprised that people actually use alpha versions, but so be it. |
Member
|
Thanks, works for me! |
pabloDeputter
added a commit
that referenced
this pull request
Oct 15, 2026
### Description boto3 spans now use `sentry.op = rpc` instead of `http.client`. Service extensions can (and will in the future) provide a more specific op with `get_span_op()`, e.g. `db` for DynamoDB. ### Why - boto3 span represents an AWS api call, not an HTTP request; the HTTP request is already captured as the as the `http.client` child - JS already also defaults AWS SDK spans to `rpc` It also lets these spans use new name and description rules in sentry-conventions, e.g. (getsentry/sentry-conventions#714, #717), e.g. `Lambda.Invoke billing` instead of `POST https://lambda.…`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.