Repository navigation
perf(ci): Use pnpm pack for tarballs - #26024
Draft
nicohrubec wants to merge 3 commits into
Draft
nicohrubec wants to merge 3 commits into
nicohrubec wants to merge 3 commits into
Conversation
nicohrubec
marked this pull request as ready for review
November 3, 2026 13:36
nicohrubec
requested review from
Lms24,
andreiborza,
chargome,
isaacs,
logaretm and
s1gr1d
and removed request for
a team
November 3, 2026 13:36
Contributor
size-limit report 📦Compared: 1f4a866 (PR test merge using develop at 5b78f8e) Against: 5b78f8e (develop) · base run #65363 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 51 successful. See the run.
Successful checks
|
logaretm
approved these changes
Nov 3, 2026
Member
Author
|
drafting for now because there are some reservations and we might postpone this to v12 |
nicohrubec
marked this pull request as draft
November 3, 2026 19:50
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
from
November 5, 2026 17:36
da14284 to
aeec453
Compare
nicohrubec
changed the base branch from
develop
to
feat/benchmark-arm-integrations
November 5, 2026 17:36
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
@nicohrubec I don't think any of those changes are breaking, which one are we worried about and why? |
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
from
November 6, 2026 07:22
aeec453 to
403ca47
Compare
nicohrubec
changed the base branch from
feat/benchmark-arm-integrations
to
feat/reduce-playwright-system-deps
November 6, 2026 07:25
nicohrubec
changed the base branch from
feat/reduce-playwright-system-deps
to
feat/benchmark-ci-sharding
November 6, 2026 09:48
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
from
November 6, 2026 09:48
403ca47 to
7f4b207
Compare
This was referenced Nov 6, 2026
nicohrubec
changed the base branch from
feat/benchmark-ci-sharding
to
feat/decouple-aws-layer-e2e
November 6, 2026 10:30
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
2 times, most recently
from
November 6, 2026 10:47
0c46257 to
149122a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 149122a. Configure here.
| "build:dev:watch": "pnpm run build:watch", | ||
| "build:transpile:watch": "ng build --configuration production --watch", | ||
| "build:tarball": "npm pack ./build", | ||
| "build:tarball": "pnpm --dir build pack --pack-destination ..", |
There was a problem hiding this comment.
Angular tarball destination may be wrong
Medium Severity
pnpm --dir build pack --pack-destination .. is not a faithful stand-in for npm pack ./build. pnpm's --dir sets the package directory without changing process cwd, and a relative --pack-destination is typically resolved from cwd, so the tarball can land in packages/ instead of packages/angular/. The upload glob packages/*/*.tgz and E2E lookup would then miss @sentry/angular. Packing build/ also runs inside the workspace without --ignore-workspace, so pnpm may pack the source package rather than ng-packagr's rewritten publish layout.
Reviewed by Cursor Bugbot for commit 149122a. Configure here.
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
force-pushed
the
feat/use-pnpm-pack
branch
from
November 6, 2026 14:12
149122a to
ac2957a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Tarball preparation delays every E2E app. Switching to
pnpm packreduces packing from 40s to 5s and the tarball job from 52s to 25s, based on one weekend measurement.Unsure about:
There are some minor changes to the packaged tarballs, but all of these probably don't matter iiuc or might even be improvements (e.g. including licenses in packages where they were missing atm). List of tarball changes courtesy of codex:
repositorychanges from a URL string to a{ type, url }object.build:tarballnow references pnpm.prepack; the build hook still runs before packing.