Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lazerg
marked this pull request as ready for review
October 29, 2026 07:05
lazerg
requested review from
andreiborza and
mydea
and removed request for
a team
October 29, 2026 07:05
Member
|
Hey, imo just fixing the comment is too shallow a fix here. I'll fix this properly and close this down. |
nicohrubec
added a commit
that referenced
this pull request
Oct 29, 2026
**Why:** The main SDK and `/request` already use the same default integrations, so passing a callback to select the default integrations is no longer necessary. This PR simplifies the setup. **How to review:** Both entry points now share `initBaseSdk()` and the same default integrations. Check that `sdk.ts` still handles optional OpenTelemetry setup, while `/request` imports only the base initializer and never reaches `sdk.ts`. Existing module-graph and OpenTelemetry tests cover this boundary. supersedes #25853 closes #24039 Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Since #22900 folded the
nodejs_compatentrypoint into the default one,getDefaultIntegrationsjust returnsgetBaseDefaultIntegrations. ThebaseSdk.tscomment still says it extends the base set, andrequest.tstells users to passgetDefaultIntegrations(options)for a fuller set, which does nothing now. This updates both comments to match. Comment-only change.Closes #24039