Skip to content

ci: Remove temporary pull_request trigger from optional E2E workflow #25817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Oct 28, 2026
Merged

ci: Remove temporary pull_request trigger from optional E2E workflow #25817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/optional-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ run-name: Optional E2E tests for ${{ inputs.commit }} (${{ inputs.correlation_id
# does not count failed checks of a dispatched run in the PR status, so these failures do not mark
# the PR as failed.
on:
# Only here so that GitHub registers this workflow before it is on the default branch, which a
# dispatch needs. The job is skipped for this event. Remove this trigger after the merge.
pull_request:
workflow_dispatch:
inputs:
commit:
Expand Down Expand Up @@ -40,7 +37,6 @@ env:
jobs:
job_optional_e2e_tests:
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
if: github.event_name == 'workflow_dispatch'
# Same cache volume as the E2E jobs in build.yml. The event is always `workflow_dispatch`, so the PR number
# decides if the run gets the PR volume.
runs-on:
Expand Down Expand Up @@ -76,8 +72,7 @@ jobs:
pnpm_config_verify_deps_before_run: 'false'
strategy:
fail-fast: false
# The fallback only keeps the expression valid for the skipped `pull_request` run.
matrix: ${{ fromJson(inputs.matrix || '{"include":[{}]}') }}
matrix: ${{ fromJson(inputs.matrix) }}

steps:
- name: Check out commit ${{ env.HEAD_COMMIT }}
Expand Down Expand Up @@ -122,7 +117,7 @@ jobs:
name: Report in PR comment
needs: [job_optional_e2e_tests]
# Not for a cancelled run: a new push cancels the old run, and the new run reports.
if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' && inputs.pr_number != '' }}
if: ${{ !cancelled() && inputs.pr_number != '' }}
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
Expand Down
Loading