Skip to content

test(node): Port Bedrock tests to span streaming #25086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 5 commits into from
Oct 7, 2026
Merged

test(node): Port Bedrock tests to span streaming #25086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90e94be
test(node): Port Bedrock tests to span streaming
nicohrubec Oct 6, 2026
0232621
test(node): Remove redundant bedrock assertions
nicohrubec Oct 6, 2026
89fa638
test(node): Use the SENTRY_ORIGIN convention in bedrock tests
nicohrubec Oct 6, 2026
19b55ee
test(node): Use convention constants for bedrock span attributes
nicohrubec Oct 6, 2026
367f6ef
Merge branch 'develop' into feat/bedrock-tests-span-streaming
nicohrubec Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/aws-serverless/bedrock/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/aws-serverless';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
69 changes: 39 additions & 30 deletions dev-packages/node-integration-tests/suites/aws-serverless/bedrock/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,55 @@
import {
GEN_AI_OPERATION_NAME,
GEN_AI_PROVIDER_NAME,
GEN_AI_REQUEST_MAX_TOKENS,
GEN_AI_REQUEST_MODEL,
GEN_AI_REQUEST_TEMPERATURE,
GEN_AI_REQUEST_TOP_P,
GEN_AI_RESPONSE_FINISH_REASONS,
GEN_AI_USAGE_INPUT_TOKENS,
GEN_AI_USAGE_OUTPUT_TOKENS,
SENTRY_OP,
SENTRY_ORIGIN,
} from '@sentry/conventions/attributes';
import type { SerializedStreamedSpanContainer } from '@sentry/core';
import { afterAll, describe, expect } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

const MODEL_ID = 'anthropic.claude-3-5-sonnet-20240620-v1:0';

function assertBedrockSpans(container: SerializedStreamedSpanContainer): void {
const segment = container.items.find(span => span.is_segment && span.name === 'Test Transaction');
expect(segment).toBeDefined();

// Converse (non-streaming)
const converseSpan = container.items.find(span => span.name === `chat ${MODEL_ID}`);
expect(converseSpan).toBeDefined();
expect(converseSpan!.status).toBe('ok');
expect(converseSpan!.attributes['sentry.origin'].value).toBe('auto.aws.aws_sdk');
expect(converseSpan!.attributes['sentry.op'].value).toBe('gen_ai.chat');
expect(converseSpan!.attributes['gen_ai.provider.name'].value).toBe('aws.bedrock');
expect(converseSpan!.attributes['gen_ai.operation.name'].value).toBe('chat');
expect(converseSpan!.attributes['gen_ai.request.model'].value).toBe(MODEL_ID);
expect(converseSpan!.attributes['gen_ai.request.max_tokens'].value).toBe(100);
expect(converseSpan!.attributes['gen_ai.request.temperature'].value).toBe(0.5);
expect(converseSpan!.attributes['gen_ai.request.top_p'].value).toBe(0.9);
expect(converseSpan!.attributes['gen_ai.usage.input_tokens'].value).toBe(12);
expect(converseSpan!.attributes['gen_ai.usage.output_tokens'].value).toBe(8);
expect(converseSpan!.attributes['gen_ai.response.finish_reasons'].value).toEqual(['end_turn']);
expect(converseSpan!.attributes[SENTRY_ORIGIN].value).toBe('auto.aws.aws_sdk');
expect(converseSpan!.attributes[SENTRY_OP].value).toBe('gen_ai.chat');
expect(converseSpan!.attributes[GEN_AI_PROVIDER_NAME].value).toBe('aws.bedrock');
expect(converseSpan!.attributes[GEN_AI_OPERATION_NAME].value).toBe('chat');
expect(converseSpan!.attributes[GEN_AI_REQUEST_MODEL].value).toBe(MODEL_ID);
expect(converseSpan!.attributes[GEN_AI_REQUEST_MAX_TOKENS].value).toBe(100);
expect(converseSpan!.attributes[GEN_AI_REQUEST_TEMPERATURE].value).toBe(0.5);
expect(converseSpan!.attributes[GEN_AI_REQUEST_TOP_P].value).toBe(0.9);
expect(converseSpan!.attributes[GEN_AI_USAGE_INPUT_TOKENS].value).toBe(12);
expect(converseSpan!.attributes[GEN_AI_USAGE_OUTPUT_TOKENS].value).toBe(8);
expect(converseSpan!.attributes[GEN_AI_RESPONSE_FINISH_REASONS].value).toEqual(['end_turn']);

// InvokeModel (non-streaming, anthropic.claude request/response body)
const invokeModelSpan = container.items.find(span => span.name === `generate_content ${MODEL_ID}`);
expect(invokeModelSpan).toBeDefined();
expect(invokeModelSpan!.status).toBe('ok');
expect(invokeModelSpan!.attributes['sentry.origin'].value).toBe('auto.aws.aws_sdk');
expect(invokeModelSpan!.attributes['sentry.op'].value).toBe('gen_ai.generate_content');
expect(invokeModelSpan!.attributes['gen_ai.provider.name'].value).toBe('aws.bedrock');
expect(invokeModelSpan!.attributes['gen_ai.operation.name'].value).toBe('generate_content');
expect(invokeModelSpan!.attributes['gen_ai.request.model'].value).toBe(MODEL_ID);
expect(invokeModelSpan!.attributes['gen_ai.request.max_tokens'].value).toBe(100);
expect(invokeModelSpan!.attributes['gen_ai.request.temperature'].value).toBe(0.5);
expect(invokeModelSpan!.attributes['gen_ai.request.top_p'].value).toBe(0.9);
expect(invokeModelSpan!.attributes['gen_ai.usage.input_tokens'].value).toBe(15);
expect(invokeModelSpan!.attributes['gen_ai.usage.output_tokens'].value).toBe(9);
expect(invokeModelSpan!.attributes['gen_ai.response.finish_reasons'].value).toEqual(['end_turn']);
expect(invokeModelSpan!.attributes[SENTRY_ORIGIN].value).toBe('auto.aws.aws_sdk');
expect(invokeModelSpan!.attributes[SENTRY_OP].value).toBe('gen_ai.generate_content');
expect(invokeModelSpan!.attributes[GEN_AI_PROVIDER_NAME].value).toBe('aws.bedrock');
expect(invokeModelSpan!.attributes[GEN_AI_OPERATION_NAME].value).toBe('generate_content');
expect(invokeModelSpan!.attributes[GEN_AI_REQUEST_MODEL].value).toBe(MODEL_ID);
expect(invokeModelSpan!.attributes[GEN_AI_REQUEST_MAX_TOKENS].value).toBe(100);
expect(invokeModelSpan!.attributes[GEN_AI_REQUEST_TEMPERATURE].value).toBe(0.5);
expect(invokeModelSpan!.attributes[GEN_AI_REQUEST_TOP_P].value).toBe(0.9);
expect(invokeModelSpan!.attributes[GEN_AI_USAGE_INPUT_TOKENS].value).toBe(15);
expect(invokeModelSpan!.attributes[GEN_AI_USAGE_OUTPUT_TOKENS].value).toBe(9);
expect(invokeModelSpan!.attributes[GEN_AI_RESPONSE_FINISH_REASONS].value).toEqual(['end_turn']);
}

describe('awsIntegration - Bedrock', () => {
Expand All @@ -49,12 +63,7 @@ describe('awsIntegration - Bedrock', () => {
'instrument.mjs',
(createTestRunner, test) => {
test('auto-instruments Bedrock Converse and InvokeModel', { timeout: 90_000 }, async () => {
await createTestRunner()
.ignore('event')
.expect({ transaction: transaction => expect(transaction.transaction).toBe('Test Transaction') })
.expect({ span: assertBedrockSpans })
.start()
.completed();
await createTestRunner().ignore('event').expect({ span: assertBedrockSpans }).start().completed();
});
},
{ additionalDependencies: { '@aws-sdk/client-bedrock-runtime': '^3.1046.0' } },
Expand Down
Loading