fix(core): Set http cookie header attributes as string arrays - #24435
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b53fee. Configure here.
| if (typeof headerValue !== 'string' || headerValue === '') { | ||
| return []; | ||
| } | ||
| return isSetCookie ? [headerValue.split(';')[0]!] : headerValue.split('; '); |
There was a problem hiding this comment.
Unguarded non-null assertion on split
Low Severity
parseCookieHeader uses a non-null assertion on the first split result with no comment explaining why a safer type is impossible. This repo's review rules require each new ! in SDK source to document that, because noUncheckedIndexedAccess makes the index look optional even though split always returns at least one element.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 5b53fee. Configure here.
JPeer264
marked this pull request as ready for review
September 16, 2026 11:02
JPeer264
requested review from
mydea and
s1gr1d
and removed request for
a team
September 16, 2026 11:02
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #24231
It is better if we send then cookies as an array as well, where each entry of the array is one key/value pair.