Skip to content

chore(test): mock @sentry/core in ember test - #24406

Merged
mydea merged 1 commit into
developfrom
isaacs/de-flake-ember-test
Sep 16, 2026
Merged

mydea merged 1 commit into
developfrom
isaacs/de-flake-ember-test

Conversation

@isaacs

@isaacs isaacs commented Sep 15, 2026

Copy link
Copy Markdown
Member

Attempt to resolve a flaky timeout by mocking the major portion of the module graph that CI is having trouble processing through vite.

┌─────────────────┬────────────┬────────┐
│                 │   before   │ after  │
├─────────────────┼────────────┼────────┤
│ ui.render test  │ 846–908 ms │ ~20 ms │
├─────────────────┼────────────┼────────┤
│ test file total │ 1101 ms    │ 173 ms │
├─────────────────┼────────────┼────────┤
│ file transform  │ 796 ms     │ 195 ms │
└─────────────────┴────────────┴────────┘

Attempt to resolve a flaky timeout by mocking the major portion of the
module graph that CI is having trouble processing through vite.

┌─────────────────┬────────────┬────────┐
│                 │   before   │ after  │
├─────────────────┼────────────┼────────┤
│ ui.render test  │ 846–908 ms │ ~20 ms │
├─────────────────┼────────────┼────────┤
│ test file total │ 1101 ms    │ 173 ms │
├─────────────────┼────────────┼────────┤
│ file transform  │ 796 ms     │ 195 ms │
└─────────────────┴────────────┴────────┘
@isaacs
isaacs requested a review from a team as a code owner September 15, 2026 21:30
@isaacs
isaacs requested review from mydea and s1gr1d and removed request for a team September 15, 2026 21:30
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.09 kB - -
@sentry/browser - with treeshaking flags 27.35 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.26 kB - -
@sentry/browser (incl. Tracing) 50.6 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 50.62 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.61 kB - -
@sentry/browser (incl. Tracing, Replay) 90.15 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.25 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 94.85 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 107.83 kB - -
@sentry/browser (incl. Feedback) 46.62 kB - -
@sentry/browser (incl. sendFeedback) 34.15 kB - -
@sentry/browser (incl. FeedbackAsync) 39.26 kB - -
@sentry/browser (incl. Metrics) 30.1 kB - -
@sentry/browser (incl. Logs) 30.35 kB - -
@sentry/browser (incl. Metrics & Logs) 31.02 kB - -
@sentry/react 30.84 kB - -
@sentry/react (incl. Tracing) 52.94 kB - -
@sentry/vue 36.34 kB - -
@sentry/vue (incl. Tracing) 52.91 kB - -
@sentry/svelte 29.11 kB - -
CDN Bundle 30.8 kB - -
CDN Bundle (incl. Tracing) 51.15 kB - -
CDN Bundle (incl. Logs, Metrics) 33.06 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.75 kB - -
CDN Bundle (incl. Tracing, Replay) 88.69 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 90.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 94.73 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 96.71 kB - -
CDN Bundle - uncompressed 91.16 kB - -
CDN Bundle (incl. Tracing) - uncompressed 152.66 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.73 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 158.61 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.14 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 272.23 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 278.17 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 285.93 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 291.86 kB - -
@sentry/nextjs (client) 55.27 kB - -
@sentry/sveltekit (client) 51.05 kB - -
@sentry/core/server 37.13 kB - -
@sentry/core/browser 13.66 kB - -
@sentry/node 132.21 kB +0.02% +18 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.03 kB - -
@sentry/node - without tracing 89.84 kB +0.04% +31 B 🔺
@sentry/node - without channel injection 111.08 kB +0.02% +13 B 🔺
@sentry/aws-serverless 98.08 kB +0.02% +18 B 🔺
@sentry/cloudflare (withSentry) - minified 203.54 kB - -
@sentry/cloudflare (withSentry) 506.83 kB - -

View base workflow run

@isaacs
isaacs added this pull request to stack #24407 September 15, 2026 21:41
@mydea
mydea merged commit 9928748 into develop Sep 16, 2026
48 checks passed
@mydea
mydea deleted the isaacs/de-flake-ember-test branch September 16, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants