fix(server-utils): Gate gen_ai.tool.definitions on dataCollection.genAI.inputs - #24088
Open
s1gr1d wants to merge 2 commits into
Open
fix(server-utils): Gate gen_ai.tool.definitions on dataCollection.genAI.inputs#24088s1gr1d wants to merge 2 commits into
gen_ai.tool.definitions on dataCollection.genAI.inputs#24088s1gr1d wants to merge 2 commits into
Conversation
…genAI.inputs` Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
marked this pull request as ready for review
September 4, 2026 12:11
s1gr1d
requested review from
stephanie-anderson
and removed request for
a team
September 4, 2026 12:11
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Resolve the recording options in `instrumentStateGraphCompile` too, so the exported entry point keeps the `dataCollection` defaults. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
requested review from
isaacs and
mydea
and removed request for
a team
September 4, 2026 12:36
|
|
||
| // This is exported, so callers can hand us an options object with no recording flags set. Resolving | ||
| // here (rather than only in `instrumentStateGraph`) keeps that path on the `dataCollection` defaults. | ||
| const options = resolveAIRecordingOptions(rawOptions); |
Contributor
There was a problem hiding this comment.
Bug: The LangGraph integration passes unresolved options to instrumentCompiledGraphInvoke, causing recordInputs to be undefined and preventing tool extraction even when globally enabled.
Severity: MEDIUM
Suggested Fix
In packages/server-utils/src/integrations/langgraph.ts, the call to wrapCompiledGraphInvoke should pass the resolvedOptions variable instead of the original options parameter. This ensures instrumentCompiledGraphInvoke receives fully resolved recording options.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/server-utils/src/ai/langgraph/index.ts#L48
Potential issue: In the diagnostics-channel integration for LangGraph, the
`wrapCompiledGraphInvoke` function is called with an unresolved `options` object. This
object is then passed to `instrumentCompiledGraphInvoke`, which incorrectly assumes the
options have been resolved. When `options.recordInputs` is `undefined`, the logic to
extract tool definitions from the graph instance is skipped. This prevents tool data
from being recorded, even if data collection for inputs is enabled globally via
`dataCollection.genAI.inputs`.
Member
Author
There was a problem hiding this comment.
False positive. Both wrapCompiledGraphInvoke calls in integrations/langgraph.ts already pass resolvedOptions (lines 58 and 87), built on line 47 from resolveAIRecordingOptions(options). The suggested fix describes what the code already does.
All three callers of instrumentCompiledGraphInvoke pass resolved options: the diagnostics-channel integration, instrumentCreateReactAgent (line 205), and instrumentStateGraphCompile since the previous commit. instrumentCompiledGraphInvoke is not exported from any package entry point, so no unresolved path is left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 0.9.1 counts tool definitions as generative AI input data, next to system instructions and prompt messages. Only the Vercel AI integration treated them that way. OpenAI, Anthropic, Google GenAI, LangChain and LangGraph attached
gen_ai.tool.definitionseven withgenAI.inputs: false, so a tool schema naming your internal endpoints still went out.Each
extractRequestAttributesnow takesrecordInputsand skips the attribute when it is off. An integration-levelrecordInputsstill wins over the global option.Fixes #24083