test(e2e): Port the create-remix-app-v2 E2E app to span streaming - #24058
Merged
Conversation
Drops the `traceLifecycle: 'static'` pin and rewrites the specs to assert on streamed spans.
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
September 4, 2026 09:45
Lms24
reviewed
Sep 4, 2026
|
|
||
| const pageLoadTransactionPromise = waitForTransaction('create-remix-app-v2', transactionEvent => { | ||
| return transactionEvent.contexts?.trace?.op === 'pageload' && transactionEvent.tags?.['sentry_test'] === testTag; | ||
| test('Links the server and client spans of one page load', async ({ page }) => { |
Member
There was a problem hiding this comment.
do we not need the testTag functionality anymore?
Member
Author
There was a problem hiding this comment.
Since these tags don't reach streamed spans, I reworked this and we are now looking at the sentry-trace via meta tags on the page to identify the pageload instead.
But good catch, the route still sets tags. Removed them in f54c399
Lms24
approved these changes
Sep 4, 2026
andreiborza
added a commit
that referenced
this pull request
Sep 4, 2026
…-app-v2 db specs (#24092) ## What Switches the two `create-remix-app-v2` db specs to the shared `collectStreamedSpansUntilSegment` helper from #24073. The explicit child-span count was redundant: the segment span ends last, so its children are already in hand once it arrives. ## Why Follow-up to #24058, which landed before the helper existed. Ref: #23807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
traceLifecycle: 'static'pin from the client entry and the server instrument file, and rewrites the transaction specs as streamed span specs. The server/client link is now proven through thesentry-tracemeta tag instead of a scope tag, because tags do not reach streamed spans.Why
Span streaming is the default, so the default E2E suite should exercise it. Static coverage moves to the new
create-remix-app-v2-staticapp (#24057).Ref: #23807