test(solidstart): Add solidstart e2e test app#12873
Merged
Merged
Conversation
chargome
approved these changes
Jul 11, 2024
andreiborza
force-pushed
the
ab/solidstart-e2e-tests
branch
2 times, most recently
from
eabdd80 to
2c053b3
Compare
andreiborza
force-pushed
the
ab/solidstart-e2e-tests
branch
from
2c053b3 to
307e997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now this only tests client side errors. It also doesn't use the solidrouter integration yet because it fails to resolve the
@sentry/solidstart/solidrouterimport properly in our repo. I have yet to figure out what exactly is causing this (my guess is some pnpm shenanigans). I couldn't reproduce this in a sample app outside of our repo yet.Closes: #12547