Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 80.50% 79.62% -0.88%
==========================================
Files 161 162 +1
Lines 13383 13562 +179
Branches 1406 1440 +34
==========================================
+ Hits 10774 10799 +25
- Misses 2078 2229 +151
- Partials 531 534 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rbro112
force-pushed
the
ryan/add_icon_uploading_to_objectstore
branch
from
91c689a to
265a811
Compare
rbro112
changed the title
rbro112
changed the title
|
Hi, please update objectstore_client to 0.0.14 (or any newer version available at the time) |
rbro112
force-pushed
the
ryan/add_icon_uploading_to_objectstore
branch
from
7d4bf0d to
b801025
Compare
rbro112
force-pushed
the
ryan/add_icon_uploading_to_objectstore
branch
from
b801025 to
2ec1e83
Compare
| artifact_id: str, | ||
| artifact: Artifact, | ||
| ) -> str | None: | ||
| if self._objectstore_client is None: |
There was a problem hiding this comment.
If for some reason objectstore_client is None (should only ever happen if the OBJECSTORE_URL env variable isn't set), this will gracefully fail and log.
We should have everything set up properly following https://github.com/getsentry/ops/blob/bc63aef2e313ac482f1ffbca826fb9273b1aa643/k8s/services/launchpad/deployment.yaml#L34
There was a problem hiding this comment.
maybe it should log an error not info?
|
|
||
|
|
||
| def get_file_size(file_path: Path) -> int: | ||
| """Get file size in bytes. |
There was a problem hiding this comment.
Any reason a bunch of the comments in this file were removed?
Adds a new preprod `/files/images/<image_id>` endpoint which allows our frontend to download images from an ID with objectstore. First to be used with app icons coming soon. Tested fully E2E locally and all works well. To work, this is reliant on landing getsentry/launchpad#430 once we get a published version of the objectstore client, but since nobody will be consuming this endpoint until we land the stacked PR (#102118) this is safe to go ahead and merge. --------- Co-authored-by: Abdullah Khan <60121741+Abdkhan14@users.noreply.github.com> Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
3 participants
Adds app icon uploading to objectstore and passes the returned objectstore id,
app_icon_id. to the update API as part of preprocessing.Likely don't want to merge this as-is as the objectstore code is just copied in, but here nonetheless in prep for merge.