fix(error-reporting): silence ResolutionError for event not found - #1598
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-RP by silencing
ResolutionErrorinstances that occur when users provide short or non-existent event IDs to commands likesentry event view.Previously,
ResolutionErrorwas not included in the silence list withinclassifySilenced()inpackages/cli/src/lib/error-reporting.ts. This led to a high volume of Sentry issues being created for expected user input errors (e.g., "Event 'a1b5d17e7682' not found."), which are not actionable CLI bugs.The fix adds
ResolutionErrorto theclassifySilenced()function, categorizing it as auser_input_error. This ensures that such errors are now properly silenced, reducing noise in Sentry and allowing focus on genuine CLI defects.Unit tests in
error-reporting.test.tshave been updated to reflect this change, verifying thatResolutionErroris now correctly silenced and a metric is emitted instead of capturing the exception.Fixes CLI-RP
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.