Skip to content

docs: explain why a quit-on-close utility can quit OpenScreen on macOS - #1107

Merged
EtienneLescot merged 2 commits into
mainfrom
docs/faq-quit-on-close
Oct 10, 2026
Merged

EtienneLescot merged 2 commits into
mainfrom
docs/faq-quit-on-close

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The "crash" in #1021 is a clean quit requested by another app. Vorssaint's Quit on close option (opt-in, in a popular menu bar toolkit) only counts windows at the normal window level, so it never counts OpenScreen's always-on-top HUD. When the HUD hides for Apple's picker, or when OpenScreen's own source window closes, Vorssaint sends a Quit Apple Event about 1.4 to 1.7 s later. OpenScreen exits with status 0 and no crash report. The full analysis is in this comment on #1021. It was reported upstream as vorssaint/vorssaint-utils#2941.

This PR documents it where users will look:

  • FAQ (website/docs/faq.md and the seven translations): a new entry that covers the cause, the fix (add OpenScreen to the utility's exceptions, or turn the option off), and a log show command that names the app that sent a quit request, whatever the utility. The Sources list gains Vorssaint, checked October 2026.
  • README: a third note in the macOS install section, next to the other macOS caveats, linking the FAQ entry. People who think OpenScreen crashed land on the README first.

Related issue

Refs #1021. It stays open until the reporter confirms the workaround.

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

None, text only.

Testing

  • npm run build in website/: all 8 locales build. The new heading's anchor why-does-openscreen-quit-on-macos-when-i-choose-what-to-record is present in each locale's FAQ page, so the README link resolves once the site deploys.
  • npm run i18n:check in website/ lists no FAQ translation as behind. The only stale files it reports are the ai-editing.md translations, which are already behind on main.
  • The cause and the workaround were reproduced on a Mac on macOS 27.0 with OpenScreen 2.0.0, the PR fix(macos): log each step of Apple's picker flow and any lost process #1100 build and Vorssaint 3.4.1:
    • Without Vorssaint, every picker flow records.
    • With Quit on close on, both of the reporter's symptoms reproduce.
    • With OpenScreen in its exceptions, both pickers record again.
  • The log show command in the entry was run on that Mac. It lists Vorssaint's quit requests, and also the one System Settings sends for "Quit & Reopen".
  • Translations: the Vorssaint labels (Quit on close, Exceptions, Add app…) stay in English, except in pt-BR, the only language Vorssaint is translated into. A native reader may want to look at the ja, zh-CN and zh-TW wording.

Summary by CodeRabbit

  • Documentation
    • Added macOS troubleshooting guidance to the README and FAQ in multiple languages for unexpected OpenScreen quits when selecting a recording source.
    • Explained how behavior differs across macOS versions and how to adjust a utility’s “quit on close” settings or identify which app requested the quit.

… macOS

Utilities such as Vorssaint's "Quit on close" only count windows at the
normal level, so they never count the always-on-top HUD. When the HUD hides
for Apple's picker, or when OpenScreen's own source window closes, they send
a Quit Apple Event and OpenScreen exits cleanly with no crash report (#1021).

Add a FAQ entry with the workaround (add OpenScreen to the utility's
exceptions) and a log command that names the app that sent the quit
request, in English and the seven translations.
People who think OpenScreen crashed land on the README first. Add a short
note to the macOS install section, next to the other macOS caveats, naming
the quit-on-close utilities and linking the FAQ entry (#1021).
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e660024b-8ba5-4bb1-9f0e-280841238ee0

📥 Commits

Reviewing files that changed from the base of the PR and between 125ebd9 and 85b06e1.


📒 Files selected for processing (9)
  • README.md
  • website/docs/faq.md
  • website/i18n/de/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/es/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/fr/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/ja/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/pt-BR/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/zh-CN/docusaurus-plugin-content-docs/current/faq.md
  • website/i18n/zh-TW/docusaurus-plugin-content-docs/current/faq.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The README and English and translated FAQ pages add guidance about unexpected OpenScreen quits during recording-source selection on macOS. The guidance describes version-specific window behavior, possible third-party utility involvement, mitigation steps, and a method to identify the app that requested the quit.

Changes

macOS quit troubleshooting

Layer / File(s) Summary
Troubleshooting guidance and localized FAQ content
README.md, website/docs/faq.md, website/i18n/*/docusaurus-plugin-content-docs/current/faq.md
The README adds a brief troubleshooting note. The FAQ pages describe the macOS version differences, possible “Quit on close” utility behavior, ways to prevent or investigate the quit, and a Vorssaint source reference.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 85b06

The added troubleshooting guidance links to the FAQ, and the inspected locale versions preserve its key steps. No material merge risk is established.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main documentation change: explaining how quit-on-close utilities can quit OpenScreen on macOS.
Description check Passed The description follows the repository template. It includes a summary, related issue, change type, release impact, desktop impact, screenshots status, and detailed testing information.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit fb30d3e into main Oct 10, 2026
21 checks passed
@EtienneLescot
EtienneLescot deleted the docs/faq-quit-on-close branch October 10, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant