Repository navigation
fix(linux): respect an explicit Ozone display backend - #1081
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable issue is identified that would prevent merging after normal checks. Pre-merge checks |
|
desktopSourceTypes pointed at main.ts for a test that now lives in wayland.ts. Restore the Vulkan rationale the move shortened, and pin that the PipeWire capturer stays on under an explicit Xwayland backend.
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Marked ready: CI green; added a follow-up commit sharing the Wayland session check with source enumeration. |
EtienneLescot
left a comment
There was a problem hiding this comment.
Reviewed: an explicit --ozone-platform is respected, Wayland stays the default. Thanks @mcmah309!
Summary
Respect an explicit
--ozone-platformchoice instead of overriding it in Wayland sessions. Wayland remains the default when no backend is specified.electron/wayland.ts: the startup Wayland setup moves out ofmain.ts;--ozone-platform=waylandis only appended when the switch is absent. The PipeWire capturer and the Vulkan opt-out stay on in every Wayland session, so capture under an explicit Xwayland backend still goes through the portal.electron/ipc/desktopSourceTypes.tsreuses the sameisWaylandSessioncheck instead of a copy.Type of change
Release impact
Desktop impact
Screenshots / video
Testing
electron/wayland.test.ts: default Wayland session, explicitx11/wayland/auto, non-Wayland session.🤖 Generated with Claude Code
Summary by CodeRabbit