fix(cli): let the Linux portal select recording sources by mcmah309 · Pull Request #1080 · getopenscreen/openscreen

mcmah309 · 2026-10-09T15:58:28Z

Summary

openscreen record on Linux with the native PipeWire helper no longer enumerates Chromium sources first. That enumeration raised a redundant portal picker before the helper's own, and could return no screens (Display index 0 not found). The portal now chooses the source, as it already does in the HUD; the CLI logs that --display and --window do not apply there.

Other capture paths are unchanged: Windows, macOS and Linux without the helper still pick and validate a source through pickSource + selectSource.

Type of change

Release impact

Patch
Minor
Major / breaking change
No release note needed

Desktop impact

Screenshots / video

Testing

src/cli/CliRecordRunner.test.tsx: native Linux skips enumeration and selection; Linux without the helper still selects, and reports a missing display.
Physical portal capture not tested.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- On Linux, recording now uses native capture’s source selection when available, skipping Chromium source enumeration and selection. The CLI reports that --display and --window don’t apply in this mode.
- When native capture is unavailable, source selection continues through Chromium, with an error reported if the requested display isn’t available.

coderabbitai · 2026-10-09T15:58:37Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 3b422757-95b0-4f35-af51-044aeb6e9f5a

📥 Commits

Reviewing files that changed from the base of the PR and between c5b2a95 and c187ecb.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: b6c658a8-f09f-480a-a7e9-4f812a20ce1d

📥 Commits

Reviewing files that changed from the base of the PR and between 870196c and c5b2a95.

📒 Files selected for processing (2)

src/cli/CliRecordRunner.test.tsx
src/cli/CliRecordRunner.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The CLI now skips Chromium source enumeration and selection when the Linux portal owns source selection. Otherwise, it retains Chromium selection and its unavailable-source error handling. Tests cover both paths.

Changes

Linux source selection

Layer / File(s)	Summary
Source selection branch and validation `src/cli/CliRecordRunner.tsx`, `src/cli/CliRecordRunner.test.tsx`	When the portal owns source selection, the runner skips Chromium enumeration and selection, and logs that `--display` and `--window` do not apply. Tests cover this path and the fallback to Chromium selection, including a missing display index.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c5b2a

On Linux with the native PipeWire helper, recording no longer enumerates Chromium sources before the portal picker opens. Other platforms keep their existing source selection. No merge-blocking risk was found.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the main change: allowing the Linux portal to select recording sources.
Description check		The description clearly explains the bug fix, affected platforms, release impact, testing, and the untested physical portal capture. The template's Related issue section is omitted, but the descriptio…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

EtienneLescot · 2026-10-10T08:44:50Z

@coderabbitai review

coderabbitai · 2026-10-10T08:45:29Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

EtienneLescot · 2026-10-10T09:08:56Z

Marked ready: CI green; follow-up logs that the portal picks the source, and drops the results-log row that recorded no manual check.

EtienneLescot · 2026-10-10T09:20:55Z

@coderabbitai review

coderabbitai · 2026-10-10T09:21:04Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

EtienneLescot · 2026-10-10T09:51:25Z

@coderabbitai review

coderabbitai · 2026-10-10T09:51:33Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

EtienneLescot

Reviewed: the Linux portal owns source selection on the native path, other capture paths unchanged. Thanks @mcmah309!

… do not apply

EtienneLescot marked this pull request as ready for review October 10, 2026 09:08

EtienneLescot self-requested a review as a code owner October 10, 2026 09:08

EtienneLescot approved these changes Oct 10, 2026

View reviewed changes

mcmah309 and others added 2 commits October 10, 2026 11:59

fix(cli): let the Linux portal select recording sources

66df18c

fix(cli): log that the portal picks the source and --display/--window…

c187ecb

… do not apply

EtienneLescot force-pushed the fix/cli-portal-source-selection branch from c5b2a95 to c187ecb Compare October 10, 2026 10:00

EtienneLescot merged commit d77c92b into getopenscreen:main Oct 10, 2026
18 checks passed

EtienneLescot mentioned this pull request Oct 10, 2026

feat(cli): add interactive project editing before export #1082

Closed

1 of 16 tasks

Navigation Menu

Repository navigation

fix(cli): let the Linux portal select recording sources - #1080

fix(cli): let the Linux portal select recording sources#1080
EtienneLescot merged 2 commits into
getopenscreen:mainfrom
mcmah309:fix/cli-portal-source-selection

mcmah309 commented Oct 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

EtienneLescot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mcmah309 commented Oct 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of change

Release impact

Desktop impact

Screenshots / video

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EtienneLescot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EtienneLescot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcmah309 commented Oct 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading