Skip to content

Enhancement: downloading torrents list for qbittorrent #4405

Merged
shamoon merged 7 commits intogethomepage:devfrom
Mindfreak9100:feature/qbit-showLeechProgress
Dec 13, 2024
Merged

Enhancement: downloading torrents list for qbittorrent #4405
shamoon merged 7 commits intogethomepage:devfrom
Mindfreak9100:feature/qbit-showLeechProgress

Conversation

@Mindfreak9100
Copy link
Copy Markdown
Contributor

@Mindfreak9100 Mindfreak9100 commented Dec 12, 2024

Proposed change

This change adds a flag enableLeechProgress to the qbittorrent widget. It will show the progress of leech/s as shown in the screenshot. It also shows the status/state of the leech as well as the ETA.
Screenshot 2024-12-12 at 3 04 25 PM

Closes #4374

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Copy Markdown
Collaborator

shamoon commented Dec 12, 2024

I will take a look at this later thanks. Can’t you just use the duration formatted though, instead of this one you wrote?

@shamoon shamoon changed the title Show progress for qbittorrent Enhancement: downloading torrents list for qbittorrent Dec 12, 2024
@shamoon shamoon enabled auto-merge (squash) December 12, 2024 23:46
Copy link
Copy Markdown
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-12 at 3 45 27 PM

Great thanks, one last thing

@shamoon shamoon disabled auto-merge December 12, 2024 23:50
@shamoon
Copy link
Copy Markdown
Collaborator

shamoon commented Dec 12, 2024

Actually one more general question: why is this limited to downloading items? Other widgets just enable the queue (all of it) or not, which would be more consistent.

@Mindfreak9100
Copy link
Copy Markdown
Contributor Author

Mindfreak9100 commented Dec 13, 2024

I understand the concept behind being consistent but I think there is more value to show the progress of downloading torrents as compared to showing everything.

The progress for seeding torrents would be always 100%, no ETA as well as the speeds for the upload will be already shown by the widget. Let me know if it makes sense.

This is my two cents and again I don't mind making changes but I feel showing only torrents being downloaded are more valuable for a dashboard like this as it shows the active downloads/ETA and progress all at once. Also as there are use cases where if the torrent is being downloaded from a private site then it would have to be seeded for a specific time. So the torrent once downloaded which is now being seeded would stay there for x amount of days.

@shamoon shamoon force-pushed the feature/qbit-showLeechProgress branch from 32c408f to 4fd88a1 Compare December 13, 2024 00:15
@shamoon shamoon enabled auto-merge (squash) December 13, 2024 00:16
@shamoon
Copy link
Copy Markdown
Collaborator

shamoon commented Dec 13, 2024

Yea, fair enough, if its a big issue for folks we can always revisit.

@shamoon shamoon merged commit 22c02f4 into gethomepage:dev Dec 13, 2024
@Mindfreak9100
Copy link
Copy Markdown
Contributor Author

Thank you @shamoon for your time and effort for being so actively involved! It's been a wonderful experience contributing to the repo.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants