Skip to content

[Android] Don't hard set play services version #134

Description

@Ehesp

Hello,

Bear in mind, I'm not to clued up to Android yet...

I keep running into the same issue whereby my build fails due to "Multiple dex files". The cause of this is conflicting play-services versions across multiple libs. This library hard sets the dep to 9.8.0.

Other libs seem to only set it to "whatever is latest", e.g: https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle#L44 & https://github.com/idehub/react-native-google-analytics-bridge/blob/master/android/build.gradle#L21

The only way I can fix these errors is by either:

  1. Adding this to my own build.gradle:
dependencies {
    compile ('com.google.android.gms:play-services-gcm:9.8.0') {
      force = true;
    }
    ...
  1. Going into node_modules, and changing the line to compile 'com.google.android.gms:play-services-base:+'.

Didn't want to make a PR since I'm not sure if this will have any repercussions?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions