Skip to content

fix: only show filename in ingest progress after 3s delay #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
four-bytes-robby merged 1 commit into from
Jun 23, 2026
Merged

fix: only show filename in ingest progress after 3s delay #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/ingest/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ const FILE_TIMEOUT_MS = 30_000; // 30 seconds per file
/** Files exceeding this duration get logged to app.log as a warning. */
const SLOW_FILE_WARN_MS = 10_000; // 10 seconds

/** Delay before showing current file name in progress (3 seconds). */
const SLOW_FILE_DISPLAY_MS = 3_000;

// ---------------------------------------------------------------------------
// Progress event helpers (gated on BRAIN_DEBUG=true)
// ---------------------------------------------------------------------------
Expand Down Expand Up @@ -203,13 +206,11 @@ export async function ingestPath(
return;
}

// Report which file is being processed
options?.progressCallback?.({
current: i + 1,
total: walkedFiles.length,
currentFile: filePath,
currentFileSize: fileStats.size,
});
// Only show filename in progress if the file takes longer than 3s
let slowFileTimer: ReturnType<typeof setTimeout> | undefined;
slowFileTimer = setTimeout(() => {
options?.progressCallback?.({ current: i + 1, total: walkedFiles.length, currentFile: filePath, currentFileSize: fileStats.size });
}, SLOW_FILE_DISPLAY_MS) as unknown as ReturnType<typeof setTimeout>;

// Read file as raw buffer — binary-safe hashing (avoids encoding issues)
let buf: ArrayBuffer;
Expand Down Expand Up @@ -437,11 +438,8 @@ export async function ingestPath(

result.filesIndexed++;
result.filesProcessed++;
options?.progressCallback?.({
current: result.filesProcessed,
total: walkedFiles.length,
currentFile: undefined,
});
if (slowFileTimer) clearTimeout(slowFileTimer);
options?.progressCallback?.({ current: result.filesProcessed, total: walkedFiles.length });

// Per-file timing debug (BRAIN_DEBUG only)
if (process.env.BRAIN_DEBUG === "true") {
Expand Down
Loading