Skip to content

Use a more deterministic way of waiting for ad widgets to be ready.#8920

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
eyebrowsoffire:adsense_unit_test_fix
Mar 27, 2025
Merged

Use a more deterministic way of waiting for ad widgets to be ready.#8920
auto-submit[bot] merged 4 commits into
flutter:mainfrom
eyebrowsoffire:adsense_unit_test_fix

Conversation

@eyebrowsoffire

@eyebrowsoffire eyebrowsoffire commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

These unit tests were failing when a skwasm change caused a subtle timing difference. See flutter/flutter#165347

@eyebrowsoffire
Use a more deterministic way of waiting for ad widgets to be ready.
86eeebe 
These unit tests were failing when a skwasm change caused a subtle timing difference.
See flutter/flutter#165347
@eyebrowsoffire eyebrowsoffire requested review from ditman and removed request for ditman March 27, 2025 19:16
ditman
ditman approved these changes Mar 27, 2025
View reviewed changes

@ditman ditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I'd make the allCalled a Future so we can race it against a timeout, and not leave the test hanging "forever" in a busy while loop; we can also spit out a better error message when the timeout fails, rather than the generic "the test timed out" failure, which is quite obscure in the CI logs.

Comment thread packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart
Comment thread packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart
Comment thread packages/google_adsense/lib/src/adsense/ad_unit_widget.dart Outdated
Comment thread packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart
@ditman

ditman commented Mar 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Ah, just noticed the Linux repo_checks. Since this is changing the implementation of the package (making the ResizeObserver non static), this needs a version roll. I think 0.1.1+1 is probably appropriate. A small CHANGELOG entry for 0.1.1+1 needs to be added as well.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025
@auto-submit auto-submit Bot merged commit a66ac0a into flutter:main Mar 27, 2025
ditman
ditman reviewed Mar 28, 2025
View reviewed changes
Comment thread packages/google_adsense/example/integration_test/experimental_ad_unit_widget_test.dart
final Stopwatch timer = Stopwatch()..start();
while (!tracker.allCalled) {
if (timer.elapsedMilliseconds > 1000) {
fail('timeout while waiting for ad widget to be injected');

@ditman ditman Mar 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
3b89794 
…ready. (flutter/packages#8920)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
6c30a63 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
f095b16 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
b5c4898 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
1298855 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
3686af0 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
8e48713 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
ea1df84 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
ade5d65 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
67ed7a1 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
574cdc0 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Closed
eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Apr 2, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading"
2095101 
This is a reland of flutter#164748, which was
reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller: flutter#165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
@eyebrowsoffire eyebrowsoffire mentioned this pull request Apr 2, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
9d1dc6f 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
e6183d5 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
9598d59 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
edeee89 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Closed
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll @bparrishMines
Roll Packages from 125c117 to 07496eb (31 revisions) (#166457)
123a6f5 
flutter/packages@125c117...07496eb

2025-04-02 alexander.irion@siemens.com [multicast_dns]
MDnsClient::listen supports onError callback (flutter/packages#8888)
2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to
use Xcode 16 and iOS 18 (flutter/packages#8968)
2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960)
2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head
meta tags (flutter/packages#8970)
2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter
discussion (flutter/packages#8924)
2025-04-01 stuartmorgan@google.com Update CODEOWNERS username
(flutter/packages#8933)
2025-04-01 69054810+M97Chahboun@users.noreply.github.com
[flutter_markdown] Added sizedImageBuilder to Markdown widget
(flutter/packages#6739)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy
of iOS tests (flutter/packages#8975)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more
hanging iOS tests (flutter/packages#8967)
2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded,
clicking close causes the callback to not be triggered correctly.
(flutter/packages#8582)
2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 2 (flutter/packages#8892)
2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter]
Skip flaky legacy tests on iOS (flutter/packages#8911)
2025-03-31 davidmartos96@gmail.com [camera_android] Don't override
default fps range when not recording (flutter/packages#8891)
2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix
typo and remove duplicitous CHANGELOG entry (flutter/packages#8754)
2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the
latest version of googleapis_auth (flutter/packages#8931)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8955)
2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash
when sending undefined message via javascript channel
(flutter/packages#8776)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/alternate_language_test_plugin/android
(flutter/packages#8946)
2025-03-31 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in
release mode (flutter/packages#8918)
2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that
hangs iOS CI (flutter/packages#8958)
2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from
b16430b to 1d954f4 (114 revisions) (flutter/packages#8922)
2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 3 (flutter/packages#8912)
2025-03-27 jacksongardner@google.com Use a more deterministic way of
waiting for ad widgets to be ready. (flutter/packages#8920)
2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 1 (flutter/packages#8890)
2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended
generics in generator methods (flutter/packages#8910)
2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix
layout issue caused by `Transform.rotate` not affecting space
calculation. (flutter/packages#8685)
2025-03-27 43759233+kenzieschmoll@users.noreply.github.com
[shared_preferences] Fix a late initialized error with the example app
(flutter/packages#8540)
2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome
dart tests (flutter/packages#8909)
2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to
base command class (flutter/packages#8730)
2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#8723)
2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods
(flutter/packages#8887)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Apr 2, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading" (#166454)
34ea67b 
This is a reland of #164748,
which was reverted here: #165350

It was reverted due to some issues in the flutter packages roller:
#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll @bparrishMines
Roll Packages from 125c117 to 07496eb (31 revisions) (#166457)
6df9322 
flutter/packages@125c117...07496eb

2025-04-02 alexander.irion@siemens.com [multicast_dns]
MDnsClient::listen supports onError callback (flutter/packages#8888)
2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to
use Xcode 16 and iOS 18 (flutter/packages#8968)
2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960)
2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head
meta tags (flutter/packages#8970)
2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter
discussion (flutter/packages#8924)
2025-04-01 stuartmorgan@google.com Update CODEOWNERS username
(flutter/packages#8933)
2025-04-01 69054810+M97Chahboun@users.noreply.github.com
[flutter_markdown] Added sizedImageBuilder to Markdown widget
(flutter/packages#6739)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy
of iOS tests (flutter/packages#8975)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more
hanging iOS tests (flutter/packages#8967)
2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded,
clicking close causes the callback to not be triggered correctly.
(flutter/packages#8582)
2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 2 (flutter/packages#8892)
2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter]
Skip flaky legacy tests on iOS (flutter/packages#8911)
2025-03-31 davidmartos96@gmail.com [camera_android] Don't override
default fps range when not recording (flutter/packages#8891)
2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix
typo and remove duplicitous CHANGELOG entry (flutter/packages#8754)
2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the
latest version of googleapis_auth (flutter/packages#8931)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8955)
2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash
when sending undefined message via javascript channel
(flutter/packages#8776)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/alternate_language_test_plugin/android
(flutter/packages#8946)
2025-03-31 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in
release mode (flutter/packages#8918)
2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that
hangs iOS CI (flutter/packages#8958)
2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from
b16430b to 1d954f4 (114 revisions) (flutter/packages#8922)
2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 3 (flutter/packages#8912)
2025-03-27 jacksongardner@google.com Use a more deterministic way of
waiting for ad widgets to be ready. (flutter/packages#8920)
2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 1 (flutter/packages#8890)
2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended
generics in generator methods (flutter/packages#8910)
2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix
layout issue caused by `Transform.rotate` not affecting space
calculation. (flutter/packages#8685)
2025-03-27 43759233+kenzieschmoll@users.noreply.github.com
[shared_preferences] Fix a late initialized error with the example app
(flutter/packages#8540)
2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome
dart tests (flutter/packages#8909)
2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to
base command class (flutter/packages#8730)
2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#8723)
2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods
(flutter/packages#8887)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
a66ac0a Use a more deterministic way of waiting for ad widgets to be …
9222169 
…ready. (flutter/packages#8920)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Apr 5, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading"
d551517 
This is a reland of flutter#164748, which was
reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller: flutter#165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@eyebrowsoffire @androidseb
Use a more deterministic way of waiting for ad widgets to be ready. (f…
d961bce 
…lutter#8920)

These unit tests were failing when a skwasm change caused a subtle timing difference. See flutter/flutter#165347
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading" (flutter#166454)
43ca43a 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @bparrishMines
Roll Packages from 125c117 to 07496eb (31 revisions) (flutter#166457)
94ea035 
flutter/packages@125c117...07496eb

2025-04-02 alexander.irion@siemens.com [multicast_dns]
MDnsClient::listen supports onError callback (flutter/packages#8888)
2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to
use Xcode 16 and iOS 18 (flutter/packages#8968)
2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960)
2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head
meta tags (flutter/packages#8970)
2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter
discussion (flutter/packages#8924)
2025-04-01 stuartmorgan@google.com Update CODEOWNERS username
(flutter/packages#8933)
2025-04-01 69054810+M97Chahboun@users.noreply.github.com
[flutter_markdown] Added sizedImageBuilder to Markdown widget
(flutter/packages#6739)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy
of iOS tests (flutter/packages#8975)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more
hanging iOS tests (flutter/packages#8967)
2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded,
clicking close causes the callback to not be triggered correctly.
(flutter/packages#8582)
2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 2 (flutter/packages#8892)
2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter]
Skip flaky legacy tests on iOS (flutter/packages#8911)
2025-03-31 davidmartos96@gmail.com [camera_android] Don't override
default fps range when not recording (flutter/packages#8891)
2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix
typo and remove duplicitous CHANGELOG entry (flutter/packages#8754)
2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the
latest version of googleapis_auth (flutter/packages#8931)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8955)
2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash
when sending undefined message via javascript channel
(flutter/packages#8776)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/alternate_language_test_plugin/android
(flutter/packages#8946)
2025-03-31 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in
release mode (flutter/packages#8918)
2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that
hangs iOS CI (flutter/packages#8958)
2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from
b16430b to 1d954f4 (114 revisions) (flutter/packages#8922)
2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 3 (flutter/packages#8912)
2025-03-27 jacksongardner@google.com Use a more deterministic way of
waiting for ad widgets to be ready. (flutter/packages#8920)
2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 1 (flutter/packages#8890)
2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended
generics in generator methods (flutter/packages#8910)
2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix
layout issue caused by `Transform.rotate` not affecting space
calculation. (flutter/packages#8685)
2025-03-27 43759233+kenzieschmoll@users.noreply.github.com
[shared_preferences] Fix a late initialized error with the example app
(flutter/packages#8540)
2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome
dart tests (flutter/packages#8909)
2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to
base command class (flutter/packages#8730)
2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#8723)
2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods
(flutter/packages#8887)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@eyebrowsoffire @FMorschel
Use a more deterministic way of waiting for ad widgets to be ready. (f…
b811a2b 
…lutter#8920)

These unit tests were failing when a skwasm change caused a subtle timing difference. See flutter/flutter#165347
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@eyebrowsoffire @romanejaquez
Reland "[skwasm] Dynamic Threading" (flutter#166454)
617aec3 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll @bparrishMines @romanejaquez
Roll Packages from 125c117 to 07496eb (31 revisions) (flutter#166457)
5d24f68 
flutter/packages@125c117...07496eb

2025-04-02 alexander.irion@siemens.com [multicast_dns]
MDnsClient::listen supports onError callback (flutter/packages#8888)
2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to
use Xcode 16 and iOS 18 (flutter/packages#8968)
2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960)
2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head
meta tags (flutter/packages#8970)
2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter
discussion (flutter/packages#8924)
2025-04-01 stuartmorgan@google.com Update CODEOWNERS username
(flutter/packages#8933)
2025-04-01 69054810+M97Chahboun@users.noreply.github.com
[flutter_markdown] Added sizedImageBuilder to Markdown widget
(flutter/packages#6739)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy
of iOS tests (flutter/packages#8975)
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more
hanging iOS tests (flutter/packages#8967)
2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded,
clicking close causes the callback to not be triggered correctly.
(flutter/packages#8582)
2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 2 (flutter/packages#8892)
2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter]
Skip flaky legacy tests on iOS (flutter/packages#8911)
2025-03-31 davidmartos96@gmail.com [camera_android] Don't override
default fps range when not recording (flutter/packages#8891)
2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix
typo and remove duplicitous CHANGELOG entry (flutter/packages#8754)
2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the
latest version of googleapis_auth (flutter/packages#8931)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8955)
2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash
when sending undefined message via javascript channel
(flutter/packages#8776)
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/alternate_language_test_plugin/android
(flutter/packages#8946)
2025-03-31 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in
release mode (flutter/packages#8918)
2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that
hangs iOS CI (flutter/packages#8958)
2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from
b16430b to 1d954f4 (114 revisions) (flutter/packages#8922)
2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 3 (flutter/packages#8912)
2025-03-27 jacksongardner@google.com Use a more deterministic way of
waiting for ad widgets to be ready. (flutter/packages#8920)
2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 1 (flutter/packages#8890)
2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended
generics in generator methods (flutter/packages#8910)
2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix
layout issue caused by `Transform.rotate` not affecting space
calculation. (flutter/packages#8685)
2025-03-27 43759233+kenzieschmoll@users.noreply.github.com
[shared_preferences] Fix a late initialized error with the example app
(flutter/packages#8540)
2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome
dart tests (flutter/packages#8909)
2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to
base command class (flutter/packages#8730)
2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#8723)
2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods
(flutter/packages#8887)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@eyebrowsoffire
Use a more deterministic way of waiting for ad widgets to be ready. (f…
4a45bfa 
…lutter#8920)

These unit tests were failing when a skwasm change caused a subtle timing difference. See flutter/flutter#165347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditman ditman ditman approved these changes

@sokoloff06 sokoloff06 Awaiting requested review from sokoloff06

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_adsense

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire @ditman