Skip to content

[pointer_interceptor] fix integration test#1675

Merged
fluttergithubbot merged 5 commits into
flutter:mainfrom
yjbanov:fix-integration-test
Apr 30, 2022
Merged

[pointer_interceptor] fix integration test#1675
fluttergithubbot merged 5 commits into
flutter:mainfrom
yjbanov:fix-integration-test

Conversation

@yjbanov

@yjbanov yjbanov commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

The pointer interceptor test was probing into some implementation details of the web engine. As of flutter-team-archive/engine#32712, the implementation has changed such that the semantics tree now sits on top of the platform views. This PR fixes the test accordingly.

Bonus:

  • Test platform interceptor both with and without semantics enabled.
  • Also test hit testing the background element directly (i.e. not just the buttons).

@ditman ditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ditman

ditman commented Apr 29, 2022

Copy link
Copy Markdown
Member

We should have picked this up with our roller, but tests for this package were being skipped. Running tests within the example directory of a package in CI is now being tracked here:

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman

ditman commented Apr 29, 2022

Copy link
Copy Markdown
Member

publishable was failing because this PR was modifying the main.dart of the example (which is published in pub.dev here). Bumped patch version so this PR can be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants