[material_ui] Update Material tokens to version 38.0.15 - #12280
Conversation
FolderOrigin-RevId: /google/src/cloud/elliottbrooks/typescale-tokens/google3/javascript/materialdesign/tokens/compiler/formats/flutter/staging_output
There was a problem hiding this comment.
Code Review
This pull request updates the generated default token data files to version 38.1.2. It replaces inline TypescaleStruct definitions with references to predefined TokenTypescale constants across multiple component files, renames TokenColor to TokenColorLight, and removes several color tokens from contrast-specific color files. Additionally, several banner and scrim token files have been deleted. As there are no review comments, no further feedback is provided.
|
|
||
| class TokenColor { |
There was a problem hiding this comment.
Part of this change includes explicitly including brightness for the color files, so the default (which was light) is now explicitly called color_light
|
|
||
| class TokenColorLightHighContrast { | ||
| /// md.sys.color.background | ||
| static const String background = '0xFFFEF7FF'; |
There was a problem hiding this comment.
We don't include background here because it's identical to the TokenColorLight.background (ditto for the other removed values)
| static const TokenColorRole labelTextColor = TokenColorRole.onSurface; | ||
|
|
||
| /// md.comp.assist-chip.label-text.type | ||
| static const TypescaleStruct labelTextType = TypescaleStruct( |
There was a problem hiding this comment.
The changes on removing non-expressive components and colors look good to me! Should we wait until this reference issue is fixed in b/538295526? Or we can also land it for now and add //TODO when we use these tokens
Contains changes introduced by the following CLs:
As part of the changes:
color_lightandcolor_darkinstead ofcolorandcolor_dark_contrast.dartfile. We only include values that are different than the default.Pre-Review Checklist
[shared_preferences]///).Text exemption: Generated code.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2