Make multiple_windows follow repo analyzer rules#184753
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Apr 15, 2026
Merged
Make multiple_windows follow repo analyzer rules#184753auto-submit[bot] merged 3 commits intoflutter:masterfrom
multiple_windows follow repo analyzer rules#184753auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the multiple_windows example by removing the local analysis_options.yaml, reordering imports, and applying consistent formatting across the project. The changes introduce explicit type annotations for variables and constants, add const modifiers to various widgets, and simplify dialog implementations by removing unnecessary async keywords and default parameters. Review feedback focuses on maintaining consistent type annotations and explicit typing for dialog calls to comply with the repository's style guidelines.
| final WindowRegistry windowRegistry = WindowRegistry.of(context); | ||
|
|
||
| late final WindowEntry entry; | ||
| final controller = DialogWindowController( |
Contributor
There was a problem hiding this comment.
To adhere to the repository's coding standards (specifically the always_specify_types rule), please provide an explicit type for the controller variable.
Suggested change
| final controller = DialogWindowController( | |
| final DialogWindowController controller = DialogWindowController( |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
| _trackers, | ||
| growable: false, | ||
| ); | ||
| final trackersCopy = List<ElementPositionTracker>.from(_trackers, growable: false); |
Contributor
There was a problem hiding this comment.
Please specify the explicit type for trackersCopy to follow the repository's style guide regarding type annotations.
Suggested change
| final trackersCopy = List<ElementPositionTracker>.from(_trackers, growable: false); | |
| final List<ElementPositionTracker> trackersCopy = List<ElementPositionTracker>.from(_trackers, growable: false); |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
| final tracker = ElementPositionTracker( | ||
| element: _popupButtonKey.currentContext!, | ||
| ); | ||
| final tracker = ElementPositionTracker(element: _popupButtonKey.currentContext!); |
Contributor
There was a problem hiding this comment.
The always_specify_types rule is followed throughout this PR. Please add the explicit type for the tracker variable here for consistency.
Suggested change
| final tracker = ElementPositionTracker(element: _popupButtonKey.currentContext!); | |
| final ElementPositionTracker tracker = ElementPositionTracker(element: _popupButtonKey.currentContext!); |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
Comment on lines
+28
to
+29
| const lowerBound = 32; | ||
| const span = 160; |
Contributor
There was a problem hiding this comment.
In the Flutter repository, it is preferred to explicitly specify types for constants. Please add int to these declarations.
Suggested change
| const lowerBound = 32; | |
| const span = 160; | |
| const int lowerBound = 32; | |
| const int span = 160; |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
| final tracker = ElementPositionTracker( | ||
| element: _tooltipButtonKey.currentContext!, | ||
| ); | ||
| final tracker = ElementPositionTracker(element: _tooltipButtonKey.currentContext!); |
Contributor
There was a problem hiding this comment.
Please provide an explicit type for the tracker variable to maintain consistency with the repository's analyzer rules.
Suggested change
| final tracker = ElementPositionTracker(element: _tooltipButtonKey.currentContext!); | |
| final ElementPositionTracker tracker = ElementPositionTracker(element: _tooltipButtonKey.currentContext!); |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
| void main() { | ||
| if (!isWindowingEnabled) { | ||
| const String windowingDisabledErrorMessage = ''' | ||
| const windowingDisabledErrorMessage = ''' |
Contributor
There was a problem hiding this comment.
The explicit type String was removed here, but the repository's style guide generally requires explicit types for all declarations. Please restore it.
Suggested change
| const windowingDisabledErrorMessage = ''' | |
| const String windowingDisabledErrorMessage = ''' |
Member
Author
There was a problem hiding this comment.
Not necessary, type is obvious from the right side.
justinmc
approved these changes
Apr 14, 2026
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
Thanks for catching this @goderbauer! I'm kind of embarrassed that I didn't notice any of these analyzer problems when I reviewed this, I guess I just rely on it to be there.
justinmc
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
master-wayne7
pushed a commit
to master-wayne7/flutter
that referenced
this pull request
Apr 15, 2026
The default `analysis_options.yaml` file created by `flutter create` was accidentally checked in for the `multiple_windows` example. It disables the repo-level analyzer rules. This deletes the custom file and adjusts the code to follow the global rules. All code fixes were implemented by Gemini.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2026
This was referenced Apr 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2026
Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions) flutter/flutter@c1b14e9...31f1802 2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145) 2026-04-16 evanwall@buffalo.edu Add oval drawing support to the SDF uber shader (flutter/flutter#184903) 2026-04-16 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137) 2026-04-16 engine-flutter-autoroll@skia.org Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131) 2026-04-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108) 2026-04-15 jacksongardner@google.com Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833) 2026-04-15 63195100+tjoengCRC@users.noreply.github.com Allow period characters in iOS and macOS framework names (flutter/flutter#184335) 2026-04-15 zemanux@users.noreply.github.com Fix SliverResizingHeader semantic focus (flutter/flutter#179690) 2026-04-15 srawlins@google.com ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063) 2026-04-15 stuartmorgan@google.com Add initial AI guidance for issues (flutter/flutter#184885) 2026-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064) 2026-04-15 jason-simmons@users.noreply.github.com Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082) 2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067) 2026-04-15 dacoharkes@google.com Agent rule: Dart editing (flutter/flutter#185045) 2026-04-15 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484) 2026-04-15 okorohelijah@google.com Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810) 2026-04-15 engine-flutter-autoroll@skia.org Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060) 2026-04-15 engine-flutter-autoroll@skia.org Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057) 2026-04-15 brackenavaron@gmail.com Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774) 2026-04-15 120367427+master-wayne7@users.noreply.github.com refactor: Remove material imports from Widget tests (flutter/flutter#184877) 2026-04-14 52160996+FMorschel@users.noreply.github.com Adds missing `await`s on forgotten cases (flutter/flutter#183466) 2026-04-14 srawlins@google.com Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830) 2026-04-14 50643541+Mairramer@users.noreply.github.com update popular issues documentation (flutter/flutter#183196) 2026-04-14 43054281+camsim99@users.noreply.github.com [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241) 2026-04-14 rmacnak@google.com [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042) 2026-04-14 goderbauer@google.com Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753) 2026-04-14 58529443+srujzs@users.noreply.github.com Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130) 2026-04-14 jesswon@google.com [AGP 9] Update AGP Error (flutter/flutter#185043) 2026-04-14 magder@google.com Move widget_preview_scaffold into pub workspace (flutter/flutter#182627) 2026-04-14 planetmarshall@users.noreply.github.com Fix gles interactive tests (flutter/flutter#181389) 2026-04-14 katelovett@google.com Update customer tests.version (flutter/flutter#185044) 2026-04-14 mdebbar@google.com [SKILL] upgrade-browser (flutter/flutter#184894) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021) 2026-04-14 mr-peipei@web.de Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294) 2026-04-14 6226493+andeart@users.noreply.github.com Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455) 2026-04-14 15619084+vashworth@users.noreply.github.com Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998) 2026-04-14 42123156+nvi9@users.noreply.github.com Fix icon tree shaking when building for desktop (flutter/flutter#184249) 2026-04-14 15619084+vashworth@users.noreply.github.com Fix killing wrong xcrun command (flutter/flutter#184831) 2026-04-14 alex.medinsh@gmail.com Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398) 2026-04-14 mdebbar@google.com [web] Async rendering for benchmarks (flutter/flutter#184677) 2026-04-14 dacoharkes@google.com [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020) 2026-04-14 737941+loic-sharma@users.noreply.github.com Skip flutter widget-preview test that times out frequently (flutter/flutter#184988) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
analysis_options.yamlfile created byflutter createwas accidentally checked in for themultiple_windowsexample. It disables the repo-level analyzer rules. This deletes the custom file and adjusts the code to follow the global rules. All code fixes were implemented by Gemini.