[vector_math] Document geometry filter APIs#22
Open
faheemabbas766 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
p: vector_math
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes public API documentation ignore rules and adds doc comments to various geometry filter classes in vector_math_geometry. Feedback suggests clarifying the documentation regarding in-place mesh mutation for inplace and InplaceGeometryFilter, and optimizing the requires and generates getters in GeometryFilter by returning const empty lists to avoid unnecessary allocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the public
PlaneAPI invector_mathandvector_math_64.This removes the file-level
public_member_api_docsignore from bothPlaneimplementations by documenting the public constructors, properties, and methods.Part of flutter/flutter#186827
Validation