Remove zypak module#497
Merged
Merged
Conversation
`zypak` is included in `org.electronjs.Electron2.BaseApp` since 2020 [1] and was already removed when the vscode flatpak started to use the electron base app [2]. It was added back in PR #300 [3], which was not really necessary, because at the time the PR was merged, `zypak` was already updated in the base app. The author of the PR requested to remove `zypak` again [4], but that never happened. [1] flathub/org.electronjs.Electron2.BaseApp#10 [2] 4538e48 [3] #300 [4] #300 (comment)
Contributor
|
Started test build 104924 |
Contributor
|
Build 104924 successful |
ghost
mentioned this pull request
Contributor
|
Started test build 106576 |
Contributor
|
Build 106576 successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zypakis included inorg.electronjs.Electron2.BaseAppsince 2020 [1] and was already removed when the vscode flatpak started to use the electron base app [2].It was added back in PR #300 [3], which was not really necessary, because at the time the PR was merged,
zypakwas already updated in the base app. The author of the PR requested to removezypakagain [4], but that never happened.[1] flathub/org.electronjs.Electron2.BaseApp#10
[2] 4538e48
[3] #300
[4] #300 (comment)