`-w`/`--wait` flag no longer works

[julien-f]

Hi,

I noticed in recent versions this flag no longer works, ie the command returns immediately without waiting for the window to close:

> flatpak run --filesystem=/tmp com.visualstudio.code -nw
> # returns with the window still opened

This breaks the use of vscode as Git editor (for commit, interactive rebase, etc.)

I'm not sure if it's related to the FlatHub version or not, I could not find any related issues on either repositories.

Best regards,

[julien-f]

I confirm that the -w flag works when not installed with flatpack.

[Drakulix]

It seems, that this issue was introduced with 3b6325a and the use of zypak. The wrapper probably does detach from the process or the code.sh script from the wrapper? I was not able to quickly find the culprit, maybe this is rather a zypak issue, then an issue of the flatpak package.

But I was able to confirm, that it works without zypak involved by running: flatpak run --command=/usr/bin/bash com.visualstudio.code -c 'env PATH="${PATH}:${XDG_DATA_HOME}/node_modules/bin" /app/extra/vscode/bin/code --no-sandbox --extensions-dir=${XDG_DATA_HOME}/vscode/extensions -w some-file

(But I would not recommend running vscode this way.)
Hopefully this is helpful for fixing this issue.

For anyone looking for a temporary workaround, downgrading to the last working version (1.57.1-1623936438) is probably the sanest approach.

[bytzo]

This issue seems to have been fixed by #300.

[julien-f]

Indeed, it appear to be working now 🙂