Enabling extensions using `FLATPAK_ENABLE_SDK_EXT` broken

[mkfrey]

Enabling extensions using FLATPAK_ENABLE_SDK_EXT does no longer work. When starting vscode from commandline, flatpak-vscode: Enabling SDK extension "<extension>" is printed, but the relevant binary paths are not added to $PATH.

[mkfrey]

The issue seems to have been introduced between commit 520cb93 and c814a7e, since it starts in flathub commit cf8a70567f4ac2ef75682b0b72923cf10235429d551689fe36538e3e0c6d56ca.

[mkfrey]

This line seems to be the culprit:

com.visualstudio.code/code.sh

Line 63 in 7aeabcc

exec env ELECTRON_RUN_AS_NODE=1 PATH="${PATH}:${XDG_DATA_HOME}/node_modules/bin" \

Setting ELECTRON_RUN_AS_NODE=1 seems to mess with the environment somehow.

[bytzo]

It looks like the addition of zypak in 3b6325a is the cause of this issue.

com.visualstudio.code/code.sh

Line 64 in 3b6325a

/app/bin/zypak-wrapper.sh /app/extra/vscode/code /app/extra/vscode/resources/app/out/cli.js \

When using zypak, the $PATH environment variable from the wrapper script is not passed to the electron binary, preventing most tools from finding the currently enabled SDKs. Since I'm not very familiar with Flatpaks or shell scripting, I'm not sure what the solution to this would be. However, as a quick workaround, you should be able to manually point your tools to the SDKs located in /usr/lib/sdk (for example, "java.home": "/usr/lib/sdk/openjdk" for the OpenJDK SDK extension).

[mkfrey]

Removing the variable ELECTRON_RUN_AS_NODE=1 fixes the issue, so I'm not sure whether the zypak addtion itself is to blame here.
Since this variable has not been set before your commit, what is its purpose and does the impact of removing it again weight more than SDKs not working?

[bytzo]

Setting the ELECTRON_RUN_AS_NODE variable allows for CLI arguments to be passed to the application. If you try removing the variable and running flatpak run com.visualstudio.code --help, the application will launch as normal instead of showing the help menu. However, you are correct that unsetting it fixes the SDK issue (I didn't notice this before, probably forgot to set FLATPAK_ENABLE_SDK_EXT when testing :P)

ELECTRON_RUN_AS_NODE was not set before since the built-in wrapper script (/app/extra/vscode/bin/code) already did it. However, since zypak must call the Electron binary directly (/app/extra/vscode/code), the wrapper script is bypassed, meaning the variable has to be set manually.

[teohhanhui]

We could patch the built-in wrapper script instead of bypassing it.

[mkfrey]

I don't know if this would change much, since the built-in wrapper does not look like it contains any meaningful difference to the custom one.

The PATH variable somehow gets eaten somwhere behind the zypak wrapper. But only if ELECTRON_RUN_AS_NODE is active.

[vteivans]

I'm having the same issue, but for me it's not just $PATH that isn't set. The npm_config_nodedir is not set either. And the only thing that enables those two lines, is running source enable.sh later.

[bytzo]

This should have been fixed by #300. I am unable to reproduce this issue with the latest Flatpak version of VSCode and the org.freedesktop.Sdk.Extension.openjdk SDK extension using the FLATPAK_ENABLE_SDK_EXT=* environment variable. Is this true for everyone else?

[YaLTeR]

The texlive extension loaded fine for me some weeks ago.