Replace HOST with BIND#120
Merged
Merged
Conversation
ThisIsMissEm
force-pushed
the
fix/replace-host-with-bind
branch
from
2a921e5 to
c31d546
Compare
ThisIsMissEm
commented
Feb 22, 2025
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
Contributor
Author
There was a problem hiding this comment.
Pointing out that translations might need to be aligned.
| LOG_QUERY=false | ||
|
|
||
| BEHIND_PROXY=false | ||
| LISTEN_PORT=3000 |
Contributor
Author
dahlia
reviewed
Feb 23, 2025
dahlia
left a comment
dahlia
left a comment
Member
There was a problem hiding this comment.
Everything looks good except for translations! I left change suggestions for them.
Co-authored-by: Hong Minhee (洪 民憙) <hong@minhee.org>
Contributor
Author
|
Updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with the container not listening on all interfaces by default (was a breaking change in #114), now BIND will only be used if it's set, otherwise it is
undefinedwhich means "listen on all interfaces")