Add .github/CODEOWNERS for review assignment#851
Conversation
Map the monorepo's paths to maintainers so GitHub auto-requests reviews from the right owners when a pull request touches a matched path. The catch-all * makes @dahlia the default fallback; each area is then owned by the maintainer(s) who authored or maintain the bulk of its changes—@2chanhaeng leads packages/uri-template/, packages/ nuxt/, packages/lint/ and the examples/, and @sij411 leads packages/ relay/ and packages/backfill/. This prepares the project for the 2026 OSSCA contributor influx by making review routing deterministic. Closes fedify-dev#788 Assisted-by: OpenCode:glm-5.2
✅ Deploy Preview for fedify-json-schema canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new ChangesCODEOWNERS setup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new .github/CODEOWNERS file to define ownership rules for the Fedify monorepo. The review feedback highlights opportunities to simplify the file by removing redundant rules, specifically the explicit entry for /.github/CODEOWNERS (which is already covered by the broader /.github/ directory rule) and the individual subdirectory entries under /examples/ (which are already covered by the /examples/ rule).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/CODEOWNERS:
- Around line 22-23: Swap the order of the two CODEOWNERS entries so the broader
/.github/ pattern comes before the more specific /.github/CODEOWNERS rule,
matching the documented precedence convention. Update the entries in CODEOWNERS
so the directory rule is listed first and the file-specific rule follows,
keeping the intended override behavior clear if owners diverge later.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 61687f12-61b9-4f1d-9774-9ecceb9e57f8
📒 Files selected for processing (1)
.github/CODEOWNERS
The explicit /.github/CODEOWNERS rule duplicated the /.github/ rule that already owns the whole directory (including the CODEOWNERS file) with the same owner, so it was dead weight and cluttered the ordering. Removing it also sidesteps the precedence-ordering nit: with only the broader /.github/ rule left, the file's "broader before specific" convention holds trivially, and the /.github/ rule still satisfies the GitHub security guidance for owning the CODEOWNERS file itself. Similarly, the individual /examples/nuxt/, /examples/sveltekit-sample/, /examples/next14-app-router/, /examples/next15-app-router/, and /examples/next-integration/ lines all repeated the /examples/ rule with the same single owner (@2chanhaeng). Since a trailing-slash pattern matches the directory and all of its subdirectories, the /examples/ rule already covers every nested example; dropping the explicit lines simplifies the file and ensures newly added examples are automatically owned by @2chanhaeng without manual updates. fedify-dev#851 (comment) fedify-dev#851 (comment) fedify-dev#851 (comment) Assisted-by: OpenCode:glm-5.2
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a .github/CODEOWNERS file to define ownership and automate review requests for the Fedify monorepo. The feedback suggests reorganizing the file to more accurately categorize cfworkers as a platform integration and amqp as a message queue, as well as updating CONTRIBUTING.md to remind contributors to update the code owners file when adding new packages.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
cfworkers is a Cloudflare Workers platform integration, not a database adapter, so it does not belong in the "Database adapters" group. amqp is a message queue driver, not a database adapter either. Rename the former "Database adapters" section to "Database adapters and message queues" to cover amqp and the MQ sides of the other adapters, and move packages/cfworkers/ into the framework section, which is renamed to "Framework and platform integrations" to reflect that it covers both web framework adapters and platform runtimes. fedify-dev#851 (comment) Assisted-by: OpenCode:glm-5.2
Now that .github/CODEOWNERS maps paths to maintainers for automatic review assignment, contributors adding a new package need to update it too; otherwise the package falls back to the default owner and skips routing to the right reviewer. Add a step to the "Adding a new package" checklist in CONTRIBUTING.md pointing at .github/CODEOWNERS. fedify-dev#851 (comment) Assisted-by: OpenCode:glm-5.2
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a .github/CODEOWNERS file to define ownership for various paths in the Fedify monorepo and updates CONTRIBUTING.md to require updating this file when adding new packages. The review feedback suggests replacing shorthand issue references (e.g., #788) with full permalink URLs to ensure the context is preserved if the repository is moved.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Jiwon Kwon has contributed to the documentation as well, so route review requests for /docs/ to her alongside Hong Minhee and ChanHaeng Lee. Assisted-by: OpenCode:glm-5.2
Custom collection dispatchers registered through FederationBuilder.setCollectionDispatcher() and setOrderedCollectionDispatcher() returned 404 Not Found after build(). The build() method copied object callbacks and type IDs onto the built federation but omitted the collection ones, so the registered routes were treated as unknown routes. build() now copies collectionCallbacks and collectionTypeIds as well, so the routes dispatch their collections. Also adds a regression test for that. Fixes #849 #851 Assisted-by: Claude Code:claude-opus-4-8
3 participants
Map the monorepo's paths to maintainers so GitHub auto-requests reviews from the right owners when a pull request touches a matched path. The catch-all
*makes @dahlia the default fallback; each area is then owned by the maintainer(s) who authored or maintain the bulk of its changes—@2chanhaeng leads packages/uri-template/, packages/nuxt/, packages/lint/ and the examples/, and @sij411 leads packages/relay/ and packages/backfill/. This prepares the project for the OSSCA 2026 contributor influx by making review routing deterministic.Fixes #788.