Skip to content

Don't reject environment variables whose value contains the = char#1715

Open
jedisct1 wants to merge 2 commits intomainfrom
fdenis/parseenvfile
Open

Don't reject environment variables whose value contains the = char#1715
jedisct1 wants to merge 2 commits intomainfrom
fdenis/parseenvfile

Conversation

@jedisct1
Copy link
Copy Markdown
Contributor

@jedisct1 jedisct1 commented Apr 3, 2026

Change summary

Variables loaded by the env_file parameter in scripts configuration couldn't include the = character (strings.Split would return more than 2 elements and fail).

For example, that made it impossible to reliably pass standard Base64-encoded values.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Users can now use environment variable values containing = characters (e.g. Base64-encoded strings) in their env_file without the CLI rejecting them.

Are there any considerations that need to be addressed for release?

None.

jedisct1 and others added 2 commits April 3, 2026 08:23
Variables loaded by the env_file parameter in scripts configuration
couldn't include the `=` character (split would return more than 2
elements and fail).

For example, that made it impossible to reliably pass standard
Base64 encoded values.
@jedisct1 jedisct1 requested a review from a team as a code owner April 3, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants