Skip to content

Fix vcl condition --comment flag#1714

Open
jedisct1 wants to merge 1 commit intomainfrom
fdenis/vclcondition
Open

Fix vcl condition --comment flag#1714
jedisct1 wants to merge 1 commit intomainfrom
fdenis/vclcondition

Conversation

@jedisct1
Copy link
Copy Markdown
Contributor

@jedisct1 jedisct1 commented Apr 3, 2026

Change summary

Fixes 2 bugs in the vcl condition update command:

  • When --comment was provided, it was overwriting the condition's statement with the comment text.
  • The no-arguments validation check did not include --comment

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • N/A

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

--comment updates the comment.

Are there any considerations that need to be addressed for release?

None.

@jedisct1 jedisct1 requested a review from a team as a code owner April 3, 2026 06:02
@jedisct1 jedisct1 requested a review from philippschulte April 3, 2026 06:02
The --comment flag was setting the statement instead of the
comment, and was missing from the no-arguments validation check.
@jedisct1 jedisct1 force-pushed the fdenis/vclcondition branch from 417ee35 to b39eff8 Compare April 3, 2026 06:30
Copy link
Copy Markdown
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants